Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] Find applications using the PATH env variable #4418

Merged
merged 17 commits into from
Jun 23, 2020

Conversation

alekhyareddy28
Copy link
Contributor

@alekhyareddy28 alekhyareddy28 commented Jun 22, 2020

Summary of the Pull Request

  • To index applications which are pointed to by the PATH environment variable.

PR Checklist

  • Applies to [Tracker, PT Run] Find applications inside environment path #4200
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

These are the changes made in this PR -

  • All the locations which are pointed to by the PATH environment variable would be indexed for applications.
  • To emulate the working of the start menu, these run commands will not show up unless the query matches the name.

eg:
Terminal -
image

Winver -
image

Validation Steps Performed

  • Added unit tests.
  • All existing unit tests pass.
  • Manually validated the working.

@alekhyareddy28 alekhyareddy28 requested a review from a team June 22, 2020 16:00
@alekhyareddy28 alekhyareddy28 added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jun 22, 2020
Copy link
Contributor

@dsrivastavv dsrivastavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alekhyareddy28 alekhyareddy28 merged commit ca99f60 into microsoft:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants