-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ImageBitmap interface #210
Conversation
@nkemnitz, |
inputfiles/addedTypes.json
Outdated
@@ -89,6 +89,120 @@ | |||
] | |||
}, | |||
{ | |||
"kind": "typedef", | |||
"flavor": "Worker", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be "Web"
, DOM interfaces are not available in Web Workers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need two entries for createImageBitMap, or at least two definitions for ImageBitmapSource
, one for WebWorkers that does not have HTMLImageElement, SVGElement, HTMLVideoElement, or HTMLCanvasElement
inputfiles/addedTypes.json
Outdated
"kind": "typedef", | ||
"flavor": "Worker", | ||
"name": "ImageBitmapSource", | ||
"type": "CanvasImageSource | Blob | ImageData" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consolodate all the types in one type def. we try to avoid polluting the global namespace.
type ImageBitmapSource = HTMLImageElement | SVGImageElement | HTMLVideoElement | HTMLCanvasElement | ImageBitmap; | Blob | ImageData;
Thanks for the explanation! The failing Travis CI build seems not related to the code changes. |
@nkemnitz, |
Closed/Reopened PR to trigger the travis-ci build (Failed yesterday due to "Service temporarily unavailable" error) |
Fixes ImageBitmap interface missing #14402
Adds interfaces
ImageBitmap
,ImageBitmapOptions
and the associated typedefs to Window and Worker scope. See WHATWG HTML Living StandardWasn't sure about the "flavor" tag.
Worker
seems to be the one I need here. but is there a description ofAll
,Web
,DOM
and maybe others?