Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split CanvasRenderingContext2D.drawImage signature #214

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Split CanvasRenderingContext2D.drawImage signature #214

merged 1 commit into from
Mar 17, 2017

Conversation

nkemnitz
Copy link
Contributor

Suggested fix for #14592.

  • provides correct parameter names for all three overloads
  • forces correct number of parameters (3, 5 or 9)
  • adds ImageBitmap as possible image source (see Added ImageBitmap interface #210)

@msftclas
Copy link

@nkemnitz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@nkemnitz nkemnitz closed this Mar 11, 2017
@nkemnitz nkemnitz reopened this Mar 11, 2017
@msftclas
Copy link

@nkemnitz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@nkemnitz
Copy link
Contributor Author

Closed/Reopened PR to trigger Travis CI - the Mono download failed yesterday.

@nkemnitz nkemnitz mentioned this pull request Mar 17, 2017
Closed
@mhegazy mhegazy merged commit dc56c29 into microsoft:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkemnitz @msftclas @mhegazy