Change Microsoft.Xaml.Interactions.Core to Microsoft.Xaml.Interactivity

[michael-hawker]

Fixes #209

The major revision is the perfect time to fix this long-standing issue with the complexity of usings behaviors involving having to remember and include multiple namespaces in XAML. This removes the warnings from CA1020 as well.

Talked to Sergio, we think just aligning on Microsoft.Xaml.Interactivity as the main namespace would make sense (it's shorter, the more familiar name, and means the core attachment point doesn't move), this would look like this:

Before:

<Button xmlns:Core="using:Microsoft.Xaml.Interactions.Core" xmlns:Interactivity="using:Microsoft.Xaml.Interactivity">
    <Interactivity:Interaction.Behaviors>
        <Core:EventTriggerBehavior EventName="Click">
            <Core:ChangePropertyAction PropertyName="Background">
                <Core:ChangePropertyAction.Value>
                    <SolidColorBrush Color="Red"/>
                </Core:ChangePropertyAction.Value>
            </Core:ChangePropertyAction>
        </Core:EventTriggerBehavior>
    </Interactivity:Interaction.Behaviors>
</Button>

After:

<Button xmlns:Interactivity="using:Microsoft.Xaml.Interactivity">
    <Interactivity:Interaction.Behaviors>
        <Interactivity:EventTriggerBehavior EventName="Click">
            <Interactivity:ChangePropertyAction PropertyName="Background">
                <Interactivity:ChangePropertyAction.Value>
                    <SolidColorBrush Color="Red"/>
                </Interactivity:ChangePropertyAction.Value>
            </Interactivity:ChangePropertyAction>
        </Interactivity:EventTriggerBehavior>
    </Interactivity:Interaction.Behaviors>
</Button>

For migration, folks should just be able to change the xmlns for Core:

<Button xmlns:Core="using:Microsoft.Xaml.Interactivity" xmlns:Interactivity="using:Microsoft.Xaml.Interactivity">
    <Interactivity:Interaction.Behaviors>
        <Core:EventTriggerBehavior EventName="Click">
            <Core:ChangePropertyAction PropertyName="Background">
                <Core:ChangePropertyAction.Value>
                    <SolidColorBrush Color="Red"/>
                </Core:ChangePropertyAction.Value>
            </Core:ChangePropertyAction>
        </Core:EventTriggerBehavior>
    </Interactivity:Interaction.Behaviors>
</Button>

[michael-hawker]

Not sure why GlobalSuppression.cs is marked as a binary... opened #283

[michael-hawker]

This is the suppression file before:

[michael-hawker]

I tested and was able to build nuget packages locally and test in a File->New WinUI 3 app:

        <Button
            xmlns:i="using:Microsoft.Xaml.Interactivity"
            x:Name="myButton"
            Content="Click Me">
            <i:Interaction.Behaviors>
                <i:EventTriggerBehavior EventName="Click">
                    <i:ChangePropertyAction
                        PropertyName="Background"
                        TargetObject="{x:Bind myButton}"
                        Value="Red" />
                </i:EventTriggerBehavior>
            </i:Interaction.Behaviors>
        </Button>

Made it so much easier to just stumble around into without having to go look up the docs for a change. ☺️

[Sergio0694]

LGTM!