Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Samples to Unified Namespace Update, and other sample clean-up #289

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

michael-hawker
Copy link
Contributor

@michael-hawker michael-hawker commented Nov 19, 2024

We accidentally broke the samples with #286 and #282 as they're in a separate solution not referenced in the main solution.

This PR intends to start fixing that, first:

  • Building samples solution in GitHub CI for validation
  • Remove old duplicate mobile page copies from sample
  • Fix samples building by updating to new pattern for 3.0 with unified namespace
  • Update sample dependency
  • Remove pfx props
  • Use file-scoped namespaces (shouldn't conflict with Switch all files to file-scoped namespaces #290 as that just does src and we just do the samples)
  • Clean-up usings

Just wanted to get the CI to validate this first before digging in so we can validate the final result.

@michael-hawker
Copy link
Contributor Author

As expected:

"D:\a\XamlBehaviors\XamlBehaviors\samples\CS\XAMLBehaviorsSample.sln" (default target) (1) ->
(Build target) ->
D:\a\XamlBehaviors\XamlBehaviors\samples\CS\XAMLBehaviorsSample.sln.metaproj : error MSB3202: The project file "D:\a\XamlBehaviors\XamlBehaviors\src\BehaviorsSDKManaged\Microsoft.Xaml.Interactions\Microsoft.Xaml.Interactions.csproj" was not found. [D:\a\XamlBehaviors\XamlBehaviors\samples\CS\XAMLBehaviorsSample.sln]

Will pick this up again tomorrow afternoon, hopefully.

@michael-hawker michael-hawker marked this pull request as ready for review November 20, 2024 01:43
@michael-hawker michael-hawker changed the title [WIP] Fix Samples Fix Samples to Unified Namespace Update, and other sample clean-up Nov 20, 2024
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!!

@Sergio0694 Sergio0694 merged commit 0f2727e into microsoft:main Nov 21, 2024
3 checks passed
@michael-hawker michael-hawker deleted the llama/fix-samples branch November 21, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants