-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge assemblies into just 'Microsoft.Xaml.Interactivity' #286
Merged
Sergio0694
merged 23 commits into
microsoft:main
from
Sergio0694:user/sergiopedri/merge-assemblies
Nov 19, 2024
Merged
Merge assemblies into just 'Microsoft.Xaml.Interactivity' #286
Sergio0694
merged 23 commits into
microsoft:main
from
Sergio0694:user/sergiopedri/merge-assemblies
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Sergio0694 your build is failing similar to my other PR, no idea what's happening, it's complaining about UAP:
Could there be some service outage or something? We literally just built |
azchohfi
reviewed
Nov 18, 2024
...DKManaged/Microsoft.Xaml.Interactivity.DesignTools/MetadataTableProvider.SurfaceIsolation.cs
Outdated
Show resolved
Hide resolved
src/BehaviorsSDKManaged/Microsoft.Xaml.Interactivity.Design/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
...viorsSDKManaged/Microsoft.Xaml.Interactivity.WinUI/Microsoft.Xaml.Interactivity.WinUI.csproj
Outdated
Show resolved
Hide resolved
azchohfi
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the solution and merges all assemblies into just 'Microsoft.Xaml.Interactivity'.
There was really no point in us shipping two .dll-s in the same NuGet package anyway.