Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medium-pass-1): register MediumPass callbacks in ActionCreator #6227

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

lisli1
Copy link
Contributor

@lisli1 lisli1 commented Dec 2, 2022

Details

This PR ensures that the MediumPass/QuickAssess equivalents of Assessment callbacks are registered in ActionCreator

Motivation

Part of feature work

Context

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn null:autoadd
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@lisli1 lisli1 requested a review from a team as a code owner December 2, 2022 06:16
@madalynrose
Copy link
Contributor

This looks great! One question: why don't we need separate callbacks for onStartOverTest and onCancelStartOver when we do have separate callbacks for onStartOverAllAssessments and onCancelStartOverAllAssessments?

Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@waabid
Copy link
Member

waabid commented Dec 2, 2022

This looks great! One question: why don't we need separate callbacks for onStartOverTest and onCancelStartOver when we do have separate callbacks for onStartOverAllAssessments and onCancelStartOverAllAssessments?

I believe it's due to telemetry event names being specific for Assessment or not. If they are not specific, we can use the same functions.

The visualization type will be different though, so we'll still be able to differentiate FWIW.

@waabid waabid merged commit dbc3811 into microsoft:main Dec 2, 2022
@lisli1 lisli1 deleted the lisli1/register-medium-pass-callbacks branch March 23, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants