Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medium-pass-1): register MediumPass callbacks in ActionCreator #6227

Merged
merged 5 commits into from
Dec 2, 2022
Merged

feat(medium-pass-1): register MediumPass callbacks in ActionCreator #6227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eaefc4
add MediumPass equivalents of registerTypeToPayloadCallback in action…
lisli1 Dec 2, 2022
c19ee92
refactor to avoid duplication of functions
lisli1 Dec 2, 2022
cf13d19
add tests for registering callbacks for mediumPass messages
lisli1 Dec 2, 2022
03138c7
add remaining unit tests
lisli1 Dec 2, 2022
edcb545
use more appropriate variable name
lisli1 Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 94 additions & 8 deletions src/background/actions/action-creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class ActionCreator {
);
this.interpreter.registerTypeToPayloadCallback(
Messages.Assessment.AssessmentScanCompleted,
this.onAssessmentScanCompleted,
this.onAssessmentScanCompletedForAssessment,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.Assessment.StartOverTest,
Expand All @@ -147,11 +147,11 @@ export class ActionCreator {
);
this.interpreter.registerTypeToPayloadCallback(
Messages.Assessment.StartOverAllAssessments,
this.onStartOverAllAssessments,
this.onStartOverAllAssessmentsForAssessment,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.Assessment.CancelStartOverAllAssessments,
this.onCancelStartOverAllAssessments,
this.onCancelStartOverAllAssessmentsForAssessment,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.Assessment.EnableVisualHelper,
Expand All @@ -170,6 +170,43 @@ export class ActionCreator {
this.onEnableVisualHelperWithoutScan,
);

this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.AssessmentScanCompleted,
this.onAssessmentScanCompletedForQuickAssess,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.StartOverTest,
this.onStartOver,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.CancelStartOver,
this.onCancelStartOver,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.StartOverAllAssessments,
this.onStartOverAllAssessmentsForQuickAssess,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.CancelStartOverAllAssessments,
this.onCancelStartOverAllAssessmentsForQuickAssess,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.EnableVisualHelper,
this.onEnableVisualHelper,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.DisableVisualHelperForTest,
this.onDisableVisualHelpersForTest,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.DisableVisualHelper,
this.onDisableVisualHelper,
);
this.interpreter.registerTypeToPayloadCallback(
Messages.MediumPass.EnableVisualHelperWithoutScan,
this.onEnableVisualHelperWithoutScan,
);

this.interpreter.registerTypeToPayloadCallback(
Messages.Inspect.SetHoveredOverSelector,
this.onSetHoveredOverSelector,
Expand Down Expand Up @@ -219,20 +256,47 @@ export class ActionCreator {
this.telemetryEventHandler.publishTelemetry(eventName, payload);
};

private onStartOverAllAssessments = async (payload: ToggleActionPayload): Promise<void> => {
const eventName = TelemetryEvents.START_OVER_ASSESSMENT;
private onStartOverAllAssessments = async (
payload: ToggleActionPayload,
eventName: string,
): Promise<void> => {
this.telemetryEventHandler.publishTelemetry(eventName, payload);
await this.visualizationActions.disableAssessmentVisualizations.invoke(
null,
this.executingScope,
);
};

private onCancelStartOverAllAssessments = (payload: BaseActionPayload): void => {
const eventName = TelemetryEvents.CANCEL_START_OVER_ASSESSMENT;
private onStartOverAllAssessmentsForAssessment = async (
payload: ToggleActionPayload,
): Promise<void> => {
await this.onStartOverAllAssessments(payload, TelemetryEvents.START_OVER_ASSESSMENT);
};

private onStartOverAllAssessmentsForQuickAssess = async (
payload: ToggleActionPayload,
): Promise<void> => {
await this.onStartOverAllAssessments(payload, TelemetryEvents.START_OVER_MEDIUM_PASS);
};

private onCancelStartOverAllAssessments = (
payload: BaseActionPayload,
eventName: string,
): void => {
this.telemetryEventHandler.publishTelemetry(eventName, payload);
};

private onCancelStartOverAllAssessmentsForAssessment = (payload: BaseActionPayload): void => {
this.onCancelStartOverAllAssessments(payload, TelemetryEvents.CANCEL_START_OVER_ASSESSMENT);
};

private onCancelStartOverAllAssessmentsForQuickAssess = (payload: BaseActionPayload): void => {
this.onCancelStartOverAllAssessments(
payload,
TelemetryEvents.CANCEL_START_OVER_MEDIUM_PASS,
);
};

private onDetailsViewClosed = async (): Promise<void> => {
await this.visualizationActions.disableAssessmentVisualizations.invoke(
null,
Expand All @@ -243,8 +307,8 @@ export class ActionCreator {
private onAssessmentScanCompleted = async (
payload: ScanCompletedPayload<any>,
tabId: number,
eventName: string,
): Promise<void> => {
const eventName = TelemetryEvents.ASSESSMENT_SCAN_COMPLETED;
this.telemetryEventHandler.publishTelemetry(eventName, payload);
await this.visualizationActions.scanCompleted.invoke(null, this.executingScope);
this.notificationCreator.createNotificationByVisualizationKey(
Expand All @@ -256,6 +320,28 @@ export class ActionCreator {
await this.targetTabController.showTargetTab(tabId, payload.testType, payload.key);
};

private onAssessmentScanCompletedForAssessment = async (
payload: ScanCompletedPayload<any>,
tabId: number,
): Promise<void> => {
await this.onAssessmentScanCompleted(
payload,
tabId,
TelemetryEvents.ASSESSMENT_SCAN_COMPLETED,
);
};

private onAssessmentScanCompletedForQuickAssess = async (
payload: ScanCompletedPayload<any>,
tabId: number,
): Promise<void> => {
await this.onAssessmentScanCompleted(
payload,
tabId,
TelemetryEvents.MEDIUM_PASS_SCAN_COMPLETED,
);
};

private onTabbedElementAdded = async (payload: AddTabbedElementPayload): Promise<void> => {
await this.visualizationScanResultActions.addTabbedElement.invoke(
payload,
Expand Down
Loading