feat(a11y-testing): add package #14797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
commented
Aug 28, 2020
| BehaviorRule.root() | ||
| .forProps({ checked: undefined, defaultChecked: true }) | ||
| .afterEvent( | ||
| 'onClick', |
There was a problem hiding this comment.
"onClick" as name of the handler is actually required only for the hooks tests. If we decide to go with only components test, this can safely be removed, as in the ComponentTestFacade we are just dispatching the event which is currently second argument.
mnajdova
commented
Aug 28, 2020
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
I couldn't commit the merge changes if I didn't replace tslint.json with .eslint.json 😕
jurokapsiar
reviewed
Aug 28, 2020
| .doesNotHaveAttribute('aria-pressed') | ||
| .description('by default'), | ||
| BehaviorRule.root() | ||
| .afterEvent( |
There was a problem hiding this comment.
could you also add afterClick(), so that we do not have to create the mouse event in every test?
There was a problem hiding this comment.
yeah that makes sense, it can be extended later for other handlers we may add 👍
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce5794f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 30205c7e182d6fd7f852b6721c55a38917785cf4 (build) |
1 task
|
Have been added in #15040. Closing for housekeeping 🏡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)