Adding a11y test packages #15040
Merged
Adding a11y test packages #15040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 45fa80d:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7d093f59a06527fc39656c903cab4470650e3acd (build) |
layershifter
approved these changes
Sep 15, 2020
ecraig12345
reviewed
Sep 15, 2020
Co-authored-by: Elizabeth Craig <[email protected]>
Co-authored-by: Elizabeth Craig <[email protected]>
kolaps33
commented
Sep 15, 2020
packages/a11y-testing/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@fluentui/eslint-plugin": "^0.54.0", | ||
| "jest": "~24.9.0", |
There was a problem hiding this comment.
I let 'jest' here because in the validate.ts file I use "test" keyword in order to generate tests:
test(rule.stringify(), () => {
validateSlot(rule, testFacade);
});
There was a problem hiding this comment.
Oh I missed that--in that case you should have "jest": "^24.0.0" in peerDependencies as well (plus jest and @types/jest in devDependencies)
There was a problem hiding this comment.
thank you :)
changes applied in the package.json file
ecraig12345
approved these changes
Sep 16, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding packages in order to use them, like in this PR:
https://github.com/microsoft/fluentui/pull/14968/files#diff-59eaeeca946dbf30b4378d6fa44b8905