Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: File Organization Convention for v9 Packages #24332

Merged
merged 5 commits into from
Aug 22, 2022
Merged

RFC: File Organization Convention for v9 Packages #24332

merged 5 commits into from
Aug 22, 2022

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Aug 10, 2022 •
edited
Loading

RFC for defining a convention on how files should be organized in v9 packages.

PREVIEW

Part of #24129

@TristanWatanabe TristanWatanabe added the Type: RFC Request for Feedback label Aug 10, 2022
@TristanWatanabe TristanWatanabe self-assigned this Aug 10, 2022
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 10, 2022
@TristanWatanabe TristanWatanabe mentioned this pull request Aug 10, 2022
Closed
59 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2022 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 1d0a72865a151962362aa3e5054ac9bf8178f09c

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e34e692:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 10, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 27a3480f5361aa5d99f8978817d8395d9037e3b7 (build)

@TristanWatanabe TristanWatanabe marked this pull request as ready for review August 10, 2022 21:20
@TristanWatanabe TristanWatanabe requested review from Hotell and a team August 10, 2022 21:20
ling1726
ling1726 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making stories location consistent makes sense to me

@TristanWatanabe TristanWatanabe merged commit d07e579 into microsoft:master Aug 22, 2022
@TristanWatanabe TristanWatanabe deleted the rfc-v9-package-folder-structure branch August 22, 2022 20:38
Hotell
Hotell reviewed Aug 23, 2022
View reviewed changes
rfcs/shared/build-system/07-standard-package-structure-for-v9.md
|- assets/
|- e2e tests
|- src/
|- common/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this common is root of evil regarding type-checking etc :P, can we remove it ? #23976

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being addressed in #24543

@trueleader trueleader mentioned this pull request Aug 24, 2022
Closed
2 tasks
@TristanWatanabe TristanWatanabe mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell left review comments

@ling1726 ling1726 ling1726 approved these changes

Assignees

@TristanWatanabe TristanWatanabe

Labels
Type: RFC Request for Feedback
Projects
None yet
Milestone
July Project Cycle Q3 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@TristanWatanabe @fabricteam @Hotell @ling1726