Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: react-hooks 8.6.8 package empty and breaks all of @fluentui/react #24499

Closed
2 tasks done
ilbrando opened this issue Aug 24, 2022 · 13 comments · Fixed by #24500
Closed
2 tasks done

[Bug]: react-hooks 8.6.8 package empty and breaks all of @fluentui/react #24499

ilbrando opened this issue Aug 24, 2022 · 13 comments · Fixed by #24500

Comments

@ilbrando
Copy link

Library

React / v8 (@fluentui/react)

System Info

N/A

Are you reporting Accessibility issue?

No response

Reproduction

https://www.npmjs.com/package/@fluentui/react-hooks

Bug Description

It appears that the package @fluentui/react-hooks version 6.8.6 is broken. I get an error when importing from it. When I inspect the package in the node_modules folder it doesn't contain a lib folder.
I have also downloaded the TGZ file at https://registry.npmjs.org/@fluentui/react-hooks/-/react-hooks-8.6.8.tgz and unpacked it. It contains these files and folders:

-rw-r--r-- 1 MIB 1049089 57472 okt 26  1985 CHANGELOG.json
-rw-r--r-- 1 MIB 1049089 32428 okt 26  1985 CHANGELOG.md
drwxr-xr-x 1 MIB 1049089     0 aug 24 13:27 config/
drwxr-xr-x 1 MIB 1049089     0 aug 24 13:27 etc/
-rw-r--r-- 1 MIB 1049089    55 okt 26  1985 just.config.ts
-rw-r--r-- 1 MIB 1049089  1259 okt 26  1985 LICENSE
-rw-r--r-- 1 MIB 1049089  1228 okt 26  1985 package.json
-rw-r--r-- 1 MIB 1049089 15603 okt 26  1985 README.md

The package.json file contains these entries:

  "main": "lib-commonjs/index.js",
  "module": "lib/index.js",
  "typings": "lib/index.d.ts",

The package is a dependency of @fluentui/react which doesn't work if you install the newest version (8.91.0).

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@ilbrando
Copy link
Author

It is the same with @fluentui/theme version 2.6.13.

@rameier
Copy link

rameier commented Aug 24, 2022

And with @fluentui/[email protected]

@RinkuMonani
Copy link

RinkuMonani commented Aug 24, 2022

In my case, fluentui doesn't have .d.ts files for some modules so imports are not being resolved.

@trueleader
Copy link

trueleader commented Aug 24, 2022

Since 8:00 looking for a reason whats the Problem in my project comes from and just stripped it down to the simplest example of empty @fluentui/theme too

I tried to fix "@fluentui/react" to a lower version, but the dependencies always loads the newest minor version

I´m not sure if this has something to do with this problem: while checking the history of all the related packages I was wondering about #24332 which should not affect v8 versions?

@blendsdk
Copy link

I have the same problem. In my case I did a fresh git clone and yarn install of my project and it breaks the react build for no apparent reason!

I get:

Module not found: Error: Can't resolve '@fluentui/react-focus' in '/Users/........./node_modules/@fluentui/react/lib'

The @fluentui/react-focus package with the correct version exists!

Any ideas?

@trueleader
Copy link

@blendsdk until the problem has been fixed, you have to use explicit versions of fluentui dependencies: #24467 (comment)
In my project I have to use the dependency block instead of overrides

@ChrisMcKee1
Copy link

Same issue, using explicit versions of fluentui dependencies does solve the problem in the short term until a fix lands.

@MarksPoint
Copy link

I just want to confirm that we're running into the same issue.
Lib folders are missing in many of the latest @FluentUI packages, causing errors.

For now the only fix is to install explicit versions of all the dependencies (typically one patch version lower than the latest is ok)

@Trish92
Copy link

Trish92 commented Aug 24, 2022

Module not found: Error: Can't resolve '@fluentui/theme'
Module not found: Error: Can't resolve '@fluentui/style-utilities'
Module not found: Error: Can't resolve '@fluentui/react-hooks'

I am seeing the same

@TristanWatanabe
Copy link
Member

This was caused by a bad publish yesterday. #24500 is the first step to fixing the issue and then we'll publish a new build.

@TristanWatanabe
Copy link
Member

A new version (8.91.1) of @fluentui/react has just been published which should have resolved the issues

@pavsaund
Copy link

Can confirm this is working for us!

@Trish92
Copy link

Trish92 commented Aug 24, 2022

Yes works fine. Thank you.

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.