Progress documentation #25194
Merged
Progress documentation #25194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 863058740bb2f3e82680db503268b3e937ddf86d (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 36e6bf6:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1319 | 1221 | 5000 | |
| Button | mount | 931 | 837 | 5000 | |
| FluentProvider | mount | 1444 | 1508 | 5000 | |
| FluentProviderWithTheme | mount | 631 | 554 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 591 | 595 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 622 | 637 | 10 | |
| MakeStyles | mount | 1802 | 1861 | 50000 | |
| SpinButton | mount | 2288 | 2348 | 5000 |
behowell
approved these changes
Oct 12, 2022
spmonahan
reviewed
Oct 12, 2022
| @@ -0,0 +1,26 @@ | |||
| # Progress Migration | |||
There was a problem hiding this comment.
IMO a better place for this documentation is in the v9 doc site but this is not a blocker for me.
To me, we should minimize the number of places documentation lives and the doc site is much more visible to our users that a Markdown file.
spmonahan
approved these changes
Oct 12, 2022
…c-react into progress-documentation
Co-authored-by: Ben Howell <[email protected]>
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* (chore): Update README and add MIGRATION.md to react-progress * change files * Apply suggestions from code review Co-authored-by: Ben Howell <[email protected]> Co-authored-by: Ben Howell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the
README.mdand add aMIGRATION.mdfile toreact-progress