-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress documentation #25194
Merged
Merged
Progress documentation #25194
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
00b560b
(chore): Update README and add MIGRATION.md to react-progress
tomi-msft 416301e
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
tomi-msft 83939bc
change files
tomi-msft aaa5116
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
tomi-msft 36e6bf6
Apply suggestions from code review
tomi-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-progress-c2e92a72-c8c9-4de6-8329-7e686f950e0c.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "prerelease", | ||
"comment": "Add documentation", | ||
"packageName": "@fluentui/react-progress", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Progress Migration | ||
|
||
## Migration from v8 | ||
|
||
v8 offers a component equivalent to v9's `Progress`. However, the API is slightly different. The main difference is that v9's `Progress` does not have the `label` or `description` props. Instead, the `label` and `hint` are located in the `ProgressField` that can be used in conjunction with `Progress`. | ||
|
||
Here's how the API of v8's `Progress` compares to the one from v9's `Progress` component: | ||
|
||
- `className` => `className` | ||
- `description` => Use `ProgressField` to use the `hint` prop | ||
- `label` => Use `ProgressField` to use the `label` prop | ||
- `onRenderProgress` => NOT SUPPORTED | ||
- `percentComplete` => Use the `value` prop | ||
- `progressHidden` => NOT SUPPORTED | ||
- `styles` => Use style customization through `className` instead | ||
|
||
## Property Mapping | ||
|
||
| v8 `ProgressIndicator` | v9 `Progress` | | ||
| ---------------------- | ------------------------------- | | ||
| `barHeight` | `thickness` | | ||
| `className` | `className` | | ||
| `componentRef` | `ref` | | ||
| `description` | use `ProgressField` hint | | ||
| `label` | use `ProgressField` label | | ||
| `percentComplete` | `value` | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO a better place for this documentation is in the v9 doc site but this is not a blocker for me.
To me, we should minimize the number of places documentation lives and the doc site is much more visible to our users that a Markdown file.