feat (CI): Enable VR Tool to run react-northstar tests for PRs #25922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanWatanabe
modified the milestones:
October Project Cycle Q4 2022,
December Project Cycle Q4 2022
TristanWatanabe
force-pushed
the
add-v0-to-VRT
branch
from
bd60f25 to
2af0909
Compare
github-actions
bot
modified the milestones:
December Project Cycle Q4 2022,
October Project Cycle Q4 2022
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1547 | 1609 | 5000 | |
| Button | mount | 1133 | 1144 | 5000 | |
| FluentProvider | mount | 1962 | 1873 | 5000 | |
| FluentProviderWithTheme | mount | 738 | 769 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 707 | 703 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 764 | 738 | 10 | |
| MakeStyles | mount | 2262 | 2272 | 50000 | |
| Persona | mount | 3696 | 3647 | 5000 | |
| SpinButton | mount | 2999 | 3054 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e7ee1eff2c65a070786a31ee1170072937c0e143 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 15ba8ad:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1190 | 1206 | 5000 | |
| Breadcrumb | mount | 3012 | 3020 | 1000 | |
| Checkbox | mount | 2755 | 2698 | 5000 | |
| CheckboxBase | mount | 2374 | 2361 | 5000 | |
| ChoiceGroup | mount | 4448 | 4426 | 5000 | |
| ComboBox | mount | 1259 | 1255 | 1000 | |
| CommandBar | mount | 9865 | 9839 | 1000 | |
| ContextualMenu | mount | 13283 | 12236 | 1000 | |
| DefaultButton | mount | 1381 | 1403 | 5000 | |
| DetailsRow | mount | 3655 | 3696 | 5000 | |
| DetailsRowFast | mount | 3656 | 3767 | 5000 | |
| DetailsRowNoStyles | mount | 3489 | 3451 | 5000 | |
| Dialog | mount | 3081 | 3162 | 1000 | |
| DocumentCardTitle | mount | 578 | 572 | 1000 | |
| Dropdown | mount | 3273 | 3246 | 5000 | |
| FocusTrapZone | mount | 2030 | 1992 | 5000 | |
| FocusZone | mount | 1967 | 1951 | 5000 | |
| GroupedList | mount | 1936 | 2197 | 2 | |
| GroupedList | virtual-rerender | 1143 | 1164 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1746 | 1682 | 2 | |
| GroupedListV2 | mount | 586 | 561 | 2 | |
| GroupedListV2 | virtual-rerender | 543 | 547 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 583 | 572 | 2 | |
| IconButton | mount | 1874 | 1950 | 5000 | |
| Label | mount | 737 | 739 | 5000 | |
| Layer | mount | 4438 | 4354 | 5000 | |
| Link | mount | 834 | 827 | 5000 | |
| MenuButton | mount | 1684 | 1687 | 5000 | |
| MessageBar | mount | 2342 | 2349 | 5000 | |
| Nav | mount | 3304 | 3259 | 1000 | |
| OverflowSet | mount | 1372 | 1390 | 5000 | |
| Panel | mount | 2625 | 2580 | 1000 | |
| Persona | mount | 1327 | 1343 | 1000 | |
| Pivot | mount | 1667 | 1664 | 1000 | |
| PrimaryButton | mount | 1567 | 1559 | 5000 | |
| Rating | mount | 7068 | 7079 | 5000 | |
| SearchBox | mount | 1552 | 1519 | 5000 | |
| Shimmer | mount | 2988 | 2890 | 5000 | |
| Slider | mount | 2072 | 2142 | 5000 | |
| SpinButton | mount | 4760 | 4735 | 5000 | |
| Spinner | mount | 814 | 806 | 5000 | |
| SplitButton | mount | 3107 | 3106 | 5000 | |
| Stack | mount | 833 | 852 | 5000 | |
| StackWithIntrinsicChildren | mount | 2491 | 2500 | 5000 | |
| StackWithTextChildren | mount | 4990 | 4985 | 5000 | |
| SwatchColorPicker | mount | 10665 | 10675 | 5000 | |
| TagPicker | mount | 2642 | 2726 | 5000 | |
| TeachingBubble | mount | 96421 | 97247 | 5000 | |
| Text | mount | 799 | 801 | 5000 | |
| TextField | mount | 1602 | 1607 | 5000 | |
| ThemeProvider | mount | 1513 | 1541 | 5000 | |
| ThemeProvider | virtual-rerender | 1068 | 1088 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2149 | 2148 | 5000 | |
| Toggle | mount | 1132 | 1164 | 5000 | |
| buttonNative | mount | 577 | 552 | 5000 |
Perf Analysis (
|
🕵 fluentuiv8 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
🕵 FluentUI-v0 Open the Visual Regressions report to inspect the 1261 screenshots✅ There was 1261 screenshots added, 0 screenshots removed, 0 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 1261 screenshots
|
TristanWatanabe
changed the title
TristanWatanabe
modified the milestones:
October Project Cycle Q4 2022,
December Project Cycle Q4 2022
TristanWatanabe
changed the title
27 tasks
github-actions
bot
modified the milestones:
December Project Cycle Q4 2022,
October Project Cycle Q4 2022
TristanWatanabe
changed the title
micahgodbolt
approved these changes
Dec 8, 2022
TristanWatanabe
changed the title
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@fluentui/react-northstartests.Related Issue(s)
Part of #25078