Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (CI): run react-northstar tests for baseline pipeline of VR tool #25926

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Dec 7, 2022

Changes:

  • Integrates react-northstar VR tests to run for baseline pipeline of new VR tool.

Related Issue(s)

Part of #25922

@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 7, 2022
@TristanWatanabe TristanWatanabe marked this pull request as ready for review December 7, 2022 22:43
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner December 7, 2022 22:43
@size-auditor
Copy link

size-auditor bot commented Dec 7, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a5ab294131ad122d9e76118183e771aeb133d9db (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 413784e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 2 screenshots removed, 1035 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png 0 Removed
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png 0 Removed

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1279 1298 5000
Button mount 912 930 5000
FluentProvider mount 1465 1510 5000
FluentProviderWithTheme mount 573 600 10
FluentProviderWithTheme virtual-rerender 539 564 10
FluentProviderWithTheme virtual-rerender-with-unmount 566 568 10
MakeStyles mount 1974 1988 50000
Persona mount 2838 2853 5000
SpinButton mount 2360 2345 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.294 kB
24.443 kB
react-alert
Alert
82.967 kB
21.022 kB
react-avatar
Avatar
51.076 kB
14.285 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
67.306 kB
18.581 kB
react-badge
Badge
23.357 kB
7.361 kB
react-badge
CounterBadge
24.247 kB
7.643 kB
react-badge
PresenceBadge
24.001 kB
7.049 kB
react-button
Button
32.923 kB
8.61 kB
react-button
CompoundButton
39.953 kB
9.933 kB
react-button
MenuButton
37.611 kB
9.942 kB
react-button
SplitButton
45.057 kB
11.323 kB
react-button
ToggleButton
48.753 kB
10.715 kB
react-card
Card - All
77.531 kB
22.328 kB
react-card
Card
72.56 kB
20.95 kB
react-card
CardFooter
8.617 kB
3.62 kB
react-card
CardHeader
10.382 kB
4.258 kB
react-card
CardPreview
9.339 kB
3.933 kB
react-combobox
Combobox (including child components)
78.546 kB
25.167 kB
react-combobox
Dropdown (including child components)
77.775 kB
25.069 kB
react-components
react-components: Button, FluentProvider & webLightTheme
59.288 kB
16.435 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
186.264 kB
52.303 kB
react-components
react-components: FluentProvider & webLightTheme
33.75 kB
11.101 kB
react-dialog
Dialog (including children components)
83.036 kB
24.754 kB
react-divider
Divider
16.515 kB
5.921 kB
react-image
Image
10.836 kB
4.283 kB
react-infobutton
InfoButton
117.922 kB
35.391 kB
react-input
Input
24.194 kB
7.89 kB
react-label
Label
9.394 kB
3.88 kB
react-link
Link
11.862 kB
4.885 kB
react-menu
Menu (including children components)
117.418 kB
36.256 kB
react-menu
Menu (including selectable components)
120.487 kB
36.785 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
57.113 kB
15.94 kB
react-popover
Popover
103.666 kB
31.858 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.536 kB
5.107 kB
react-provider
FluentProvider
15.817 kB
5.905 kB
react-radio
Radio
36.42 kB
12.126 kB
react-radio
RadioGroup
14.304 kB
5.72 kB
react-select
Select
23.474 kB
8.017 kB
react-slider
Slider
32.091 kB
10.183 kB
react-spinbutton
SpinButton
44.502 kB
12.812 kB
react-spinner
Spinner
20.013 kB
6.446 kB
react-switch
Switch
33.427 kB
10.581 kB
react-text
Text - Default
11.838 kB
4.625 kB
react-text
Text - Wrappers
15.148 kB
5.06 kB
react-textarea
Textarea
25.733 kB
8.328 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
30.908 kB
6.714 kB
react-theme
Teams: Light theme
17.776 kB
5.141 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against a5ab294131ad122d9e76118183e771aeb133d9db

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 2187 1189 5000 Possible regression
GroupedList mount 1948 2231 2 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 2187 1189 5000 Possible regression
Breadcrumb mount 3087 3088 1000
Checkbox mount 2666 2671 5000
CheckboxBase mount 2404 2414 5000
ChoiceGroup mount 4496 4499 5000
ComboBox mount 1285 1249 1000
CommandBar mount 10009 9981 1000
ContextualMenu mount 12607 12846 1000
DefaultButton mount 1386 1393 5000
DetailsRow mount 3643 3688 5000
DetailsRowFast mount 3670 3720 5000
DetailsRowNoStyles mount 3520 3526 5000
Dialog mount 3166 3183 1000
DocumentCardTitle mount 570 572 1000
Dropdown mount 3260 3231 5000
FocusTrapZone mount 2052 2074 5000
FocusZone mount 2049 1973 5000
GroupedList mount 1948 2231 2 Possible regression
GroupedList virtual-rerender 1184 1139 2
GroupedList virtual-rerender-with-unmount 1714 1713 2
GroupedListV2 mount 579 558 2
GroupedListV2 virtual-rerender 550 564 2
GroupedListV2 virtual-rerender-with-unmount 581 588 2
IconButton mount 1910 1927 5000
Label mount 746 740 5000
Layer mount 4414 4371 5000
Link mount 831 841 5000
MenuButton mount 1693 1710 5000
MessageBar mount 2387 2401 5000
Nav mount 3313 3284 1000
OverflowSet mount 1370 1376 5000
Panel mount 2550 2548 1000
Persona mount 1345 1302 1000
Pivot mount 1657 1652 1000
PrimaryButton mount 1511 1553 5000
Rating mount 6641 6574 5000
SearchBox mount 1441 1402 5000
Shimmer mount 2808 2908 5000
Slider mount 1922 1925 5000
SpinButton mount 4630 4554 5000
Spinner mount 786 812 5000
SplitButton mount 3012 3094 5000
Stack mount 841 805 5000
StackWithIntrinsicChildren mount 2188 2223 5000
StackWithTextChildren mount 4635 4775 5000
SwatchColorPicker mount 10346 9757 5000
TagPicker mount 2548 2713 5000
TeachingBubble mount 100165 99508 5000
Text mount 774 796 5000
TextField mount 1588 1500 5000
ThemeProvider mount 1476 1484 5000
ThemeProvider virtual-rerender 1026 1091 5000
ThemeProvider virtual-rerender-with-unmount 2161 2040 5000
Toggle mount 1090 1101 5000
buttonNative mount 554 552 5000

@TristanWatanabe TristanWatanabe merged commit 0385e22 into microsoft:master Dec 8, 2022
@TristanWatanabe TristanWatanabe deleted the v0-add-to-pr branch December 8, 2022 00:20
@TristanWatanabe TristanWatanabe changed the title feat (CI): Enable VR Tool to run react-northstar tests for PRs feat (CI): run react-northstar tests for baseline pipeline of VR tool Dec 8, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants