Add test retries on Windows CI #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested changes
Mar 15, 2022
Also replace '%v' with %q when possible.
qmuntal
approved these changes
Mar 15, 2022
chsienki
approved these changes
Apr 7, 2022
dagood
added a commit
to dagood/go
that referenced
this pull request
Apr 13, 2022
* Add test retries on Windows CI * Delete unnecessary funcs, reject empty string, check earlier * Fix test run: don't reuse cmd, remove redundant runCmd Also replace '%v' with %q when possible. (cherry picked from commit 20d9986)
dagood
added a commit
to dagood/go
that referenced
this pull request
Apr 20, 2022
* Add test retries on Windows CI * Delete unnecessary funcs, reject empty string, check earlier * Fix test run: don't reuse cmd, remove redundant runCmd Also replace '%v' with %q when possible. (cherry picked from commit 20d9986)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retries to the test portion of the Windows builds in CI, not just build. Test retries are a separate retry context, so the build won't have to also retry--hopefully this makes it so the AzDO job won't completely time out.
Better solutions are possible (skip specific tests in innerloop CI, break apart the test run into "never fail" and "retry" sections, improve Windows' reliability), but those are more difficult, and aren't sure to work. Adding blanket retries takes the pressure off until we can focus on Windows test reliability.
AzDO only allows retrying a failed job once all jobs in the stage have completed, so these retries will improve PR validation wall clock time. This also means a dev won't have to manually monitor their jobs to retry as soon as they can after a Windows flakiness issue shows up.