Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microsoft/dev.boringcrypto.go1.18] Update VERSION to go1.18 #487

Conversation

dagood
Copy link
Member

@dagood dagood commented Mar 16, 2022

Upstream doesn't maintain this file, so we have our copy that we update. This is ingested into the build asset JSON and used to generate the Dockerfiles, etc. in microsoft/go-images.

This is something I'm eager to get into automatic release infrastructure.

@dagood dagood enabled auto-merge (squash) March 16, 2022 22:01
@dagood
Copy link
Member Author

dagood commented Mar 16, 2022

windows-amd64-test failed with flakiness, I hit retry:

##### moved GOROOT
ok  	fmt	0.097s
go tool dist: failed to restore GOROOT: rename D:\a\1\s\go-moved D:\a\1\s\go: Access is denied.

=== Errors
go tool dist: failed to restore GOROOT: rename D:\a\1\s\go-moved D:\a\1\s\go: Access is denied.

DONE 14480 tests, 1127 skipped, 1 error in 1057.878s

This is an example of what we can only assume is a failure caused by antivirus locking. We have this thread about the way it showed up when it was happening in the build stage (now the build stage auto-retries, and we're hitting it in the test stage):

Just pointing it out because it came up recently in a standup meeting about this PR I have open to add auto-retries to this part of the Windows jobs, too:

@dagood dagood merged commit 6450939 into microsoft:microsoft/dev.boringcrypto.go1.18 Mar 16, 2022
@dagood dagood deleted the dev/dagood/update-version-1.18-fips branch March 16, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants