Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with HorizontalContentAlignment not working on NavigationViewItem #1325

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Fix bug with HorizontalContentAlignment not working on NavigationViewItem #1325

merged 3 commits into from
Sep 16, 2019

Conversation

marcelwgn
Copy link
Collaborator

Summary

Fixed a bug where setting the HorizontalContentAlignment of a NavigationViewItem would not be applied.

Motivation

Fixes #481

Screenshots

image

@marcelwgn marcelwgn requested a review from a team as a code owner September 13, 2019 09:09
@marcelwgn marcelwgn closed this Sep 13, 2019
@marcelwgn marcelwgn deleted the navview-item-horizcontalign branch September 13, 2019 11:49
@marcelwgn marcelwgn restored the navview-item-horizcontalign branch September 13, 2019 11:50
@marcelwgn marcelwgn reopened this Sep 13, 2019
@jevansaks jevansaks added needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) release note PR that we want to call out in the next release summary labels Sep 13, 2019
@kaiguo
Copy link
Contributor

kaiguo commented Sep 13, 2019

@chingucoding Thanks for the fix!

From the screenshots looks like you created a test page locally to test out the changes. Can you add your page here? I'm working on visual tree verification tests and hopefully we'll be able to capture visual changes like this in the visual tree.

@marcelwgn
Copy link
Collaborator Author

marcelwgn commented Sep 13, 2019 •
edited
Loading

Sure, I will do this over the weekend. Should I just add the page or should I also wire the page into the "NavigationView Navigation" (the page with all the buttons leading to different NavigationView test-pages) too? Is there anything I need to watch out for?

@kaiguo
Copy link
Contributor

kaiguo commented Sep 13, 2019

Sure, I will do this over the weekend. Should I just add the page or should I also wire the page into the "NavigationView Navigation" (the page with all the buttons leading to different NavigationView test-pages) too? Is there anything I need to watch out for?

It would be the best if you can wire it, that way I can easily add a visual tree verification test for that when infrastructure is ready. Other than that, nothing special you need to watch for I guess, just add what you currently have to the new page and we should be good to go. Thanks!

@kaiguo
Copy link
Contributor

kaiguo commented Sep 15, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kaiguo kaiguo merged commit 259054e into microsoft:master Sep 16, 2019
jevansaks pushed a commit that referenced this pull request Sep 17, 2019
@marcelwgn @jevansaks
Fix bug with HorizontalContentAlignment not working on NavigationView…
67537d9 
…Item (#1325)

* Fix bug with NavViewItem HorizontalContentAlignment , Closes #481

* Improve visual behaviour

* Add testpage für NavView Menuitem content stretch
@jevansaks jevansaks removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Sep 17, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190917002 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Sep 19, 2019
Closed
@marcelwgn marcelwgn deleted the navview-item-horizcontalign branch September 23, 2019 07:55
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.3.191007001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiguo kaiguo kaiguo approved these changes

Assignees
No one assigned
Labels
release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NavigationViewItem does not respect HorizontalContentAlignment
4 participants
@marcelwgn @kaiguo @msft-github-bot @jevansaks