-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] TabViewItem close button custom tooltip #2022
Merged
ranjeshj
merged 6 commits into
microsoft:master
from
Felix-Dev:user/Felix-Dev/tabviewclosebuttontooltip
Mar 6, 2020
Merged
[WIP] TabViewItem close button custom tooltip #2022
ranjeshj
merged 6 commits into
microsoft:master
from
Felix-Dev:user/Felix-Dev/tabviewclosebuttontooltip
Mar 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
Issue needs to be triaged by the area owners
label
Feb 25, 2020
marcelwgn
reviewed
Feb 25, 2020
ranjeshj
added
area-TabView
team-Controls
Issue for the Controls team
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Feb 26, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
teaP
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a custom tooltip to the Close button of the tab items of a TabView. The tooltip will describe the action taken on button click as well as the keyboard shortcut used to invoke tab closing.
Motivation and Context
Closes #2018.
How Has This Been Tested?
Tested visually for now.
Screenshots (if appropriate):
Tooltip with available keyboard accelerator (RS3+):
Tooltip without keyboard accelerator:
Open Questions
(Ctrl+F4)
independently from the chosen language. Optimally, localized values will be provided (such as(Strg+F4)
for German).be-BY, bn-BD, sw-KE, uz-Latn-UZ
Each of them has an Automation name and localized tooltip content for the TabView's Add button though. Because the Automation name is missing for them, I also did not add a localized tooltip text for the Close button for these languages.