Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] TabViewItem close button custom tooltip #2022

Merged

Conversation

Felix-Dev
Copy link
Contributor

@Felix-Dev Felix-Dev commented Feb 25, 2020

Description

This PR adds a custom tooltip to the Close button of the tab items of a TabView. The tooltip will describe the action taken on button click as well as the keyboard shortcut used to invoke tab closing.

Motivation and Context

Closes #2018.

How Has This Been Tested?

Tested visually for now.

Screenshots (if appropriate):

Tooltip with available keyboard accelerator (RS3+):
image
Tooltip without keyboard accelerator:
image

Open Questions

  1. Currently, the keyboard accelerator text, if available, displays (Ctrl+F4) independently from the chosen language. Optimally, localized values will be provided (such as (Strg+F4) for German).
  2. When adding localization for "Close tab" I noticed the Automation name for the Close button (which I based the tooltip localization on) is missing for the following languages:
    be-BY, bn-BD, sw-KE, uz-Latn-UZ
    Each of them has an Automation name and localized tooltip content for the TabView's Add button though. Because the Automation name is missing for them, I also did not add a localized tooltip text for the Close button for these languages.
  3. See comments in TabView.cpp/.h and TabViewItem.cpp for specific implementation questions.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Feb 25, 2020
@msftclas
Copy link

msftclas commented Feb 25, 2020

CLA assistant check
All CLA requirements met.

dev/TabView/TabViewItem.cpp Outdated Show resolved Hide resolved
dev/TabView/TabViewItem.cpp Outdated Show resolved Hide resolved
@ranjeshj ranjeshj requested a review from teaP February 26, 2020 16:58
@ranjeshj ranjeshj added area-TabView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 26, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit 9c1eb67 into microsoft:master Mar 6, 2020
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/tabviewclosebuttontooltip branch March 6, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView: Close button of tab items shows item header on hover
7 participants