Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] TabViewItem close button custom tooltip #2022

Merged
merged 6 commits into from
Mar 6, 2020
Merged

[WIP] TabViewItem close button custom tooltip #2022

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c1c489
Add custom tooltip to a tab item's close button (not yet localized).
Felix-Dev Feb 24, 2020
c058541
Add localization resources for "Close tab"
Felix-Dev Feb 24, 2020
9f6ef9e
Address string appending feedback
Felix-Dev Feb 25, 2020
454f53c
Minor changes (coding style, TODO comment removed)
Felix-Dev Feb 25, 2020
8b3f549
Revert "Add localization resources for "Close tab""
Felix-Dev Feb 27, 2020
8d660ba
Addresses localization feedback.
Felix-Dev Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev/ResourceHelper/ResourceAccessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ class ResourceAccessor sealed
#define SR_TabViewAddButtonName L"TabViewAddButtonName"
#define SR_TabViewAddButtonTooltip L"TabViewAddButtonTooltip"
#define SR_TabViewCloseButtonName L"TabViewCloseButtonName"
#define SR_TabViewCloseButtonTooltip L"TabViewCloseButtonTooltip"
#define SR_NumberBoxUpSpinButtonName L"NumberBoxUpSpinButtonName"
#define SR_NumberBoxDownSpinButtonName L"NumberBoxDownSpinButtonName"

Expand Down
4 changes: 4 additions & 0 deletions dev/TabView/Strings/af-ZA/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Sluit duimgids</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Sluit duimgids</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/am-ET/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>ትር ዝጋ</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>ትር ዝጋ</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/ar-SA/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>إغلاق علامة التبويب</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>إغلاق علامة التبويب</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/az-Latn-AZ/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Tab-vərəqəni bağla</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Tab-vərəqəni bağla</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/bg-BG/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Затваряне на раздел</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Затваряне на раздел</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/bs-Latn-BA/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Zatvori karticu</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Zatvori karticu</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/ca-ES/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Tanca la pestanya</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Tanca la pestanya</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/cs-CZ/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Zavřít kartu</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Zavřít kartu</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/da-DK/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Luk fane</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Luk fane</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/de-DE/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Tab schließen</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Tab schließen</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/el-GR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Κλείσιμο καρτέλας</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Κλείσιμο καρτέλας</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/en-GB/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Close Tab</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Close tab</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Close Tab</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Close tab</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/es-ES/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Cerrar pestaña</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Cerrar pestaña</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/es-MX/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Cerrar pestaña</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Cerrar pestaña</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/et-EE/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Sule vahekaart</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Sule vahekaart</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/eu-ES/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Itxi fitxa</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Itxi fitxa</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/fa-IR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>بستن زبانه</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>بستن زبانه</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/fi-FI/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Sulje välilehti</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Sulje välilehti</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/fil-PH/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Isara ang tab</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Isara ang tab</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/fr-CA/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Fermer l'onglet</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Fermer l'onglet</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/fr-FR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Fermer l’onglet</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Fermer l’onglet</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/gl-ES/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Pechar separador</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Pechar separador</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/he-IL/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>סגור כרטיסיה</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>סגור כרטיסיה</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/hi-IN/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>टैब बंद करें</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>टैब बंद करें</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/hr-HR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Zatvori karticu</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Zatvori karticu</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/hu-HU/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Lap bezárása</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Lap bezárása</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/id-ID/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Tutup Tab</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Tutup Tab</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/is-IS/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Loka flipa</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Loka flipa</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/it-IT/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Chiudi scheda</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Chiudi scheda</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/ja-JP/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>タブを閉じる</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>タブを閉じる</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/ka-GE/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>ჩანართის დახურვა</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>ჩანართის დახურვა</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/kk-KZ/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Қойыншаны жабу</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Қойыншаны жабу</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/km-KH/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>បិទ​ថេប</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>បិទ​ថេប</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/kn-IN/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>ಟ್ಯಾಬ್ ಮುಚ್ಚಿ</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>ಟ್ಯಾಬ್ ಮುಚ್ಚಿ</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/ko-KR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>탭 닫기</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>탭 닫기</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/lo-LA/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>ປິດ​ແຖບ</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>ປິດ​ແຖບ</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/lt-LT/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Uždaryti skirtuką</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Uždaryti skirtuką</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
4 changes: 4 additions & 0 deletions dev/TabView/Strings/lv-LV/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@
<value>Aizvērt cilni</value>
<comment>Automation name for the close button on each tab.</comment>
</data>
<data name="TabViewCloseButtonTooltip" xml:space="preserve">
<value>Aizvērt cilni</value>
<comment>Tooltip for the close button on each tab.</comment>
</data>
</root>
Loading