This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyser2003
force-pushed
the
master
branch
2 times, most recently
from
December 4, 2019 17:38
caf3f94
to
bfc5b5a
Compare
44 tasks
SparkSnail
reviewed
Dec 15, 2019
"singular": "tfjob" | ||
} | ||
}, | ||
"apiVersion": "apiextensions.k8s.io/v1beta1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1beta1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubeflow/tf-operator/blob/master/examples/crd/crd-v1.yaml
They use it so here.
SparkSnail
approved these changes
Dec 17, 2019
please fix conflict @skyser2003 |
chicm-ms
previously approved these changes
Dec 18, 2019
chicm-ms
approved these changes
Dec 20, 2019
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubeflow 0.7 supports apiVersion v1 for tf-operator