add support for pytorchjob crd version 'v1' #2061
Conversation
|
|
| "singular": "pytorchjob" | ||
| } | ||
| }, | ||
| "apiVersion": "apiextensions.k8s.io/v1beta1", |
There was a problem hiding this comment.
https://github.com/kubeflow/tf-operator/blob/master/examples/crd/crd-v1.yaml
They use it so here.
There was a problem hiding this comment.
Already have test it. it's working :)
There was a problem hiding this comment.
Checked again, https://github.com/kubeflow/pytorch-operator/blob/master/examples/mnist/v1/pytorch_job_mnist_nccl.yaml using apiVersion: "kubeflow.org/v1" instead of "apiVersion": "apiextensions.k8s.io/v1beta1".
Will get back after doing more tests.
There was a problem hiding this comment.
Thanks for the test, better to use apiVersion: "kubeflow.org/v1" since it's more clear.
There was a problem hiding this comment.
Tests have been done. Turns out both "kubeflow.org/v1" and "apiextensions.k8s.io/v1beta1" are working well. As you mentioned, better to use apiVersion: "kubeflow.org/v1" since it's more clear. The code has been updated, please kindly have a look
As supported by kubeflow 0.7, the new crd version
v1has been added forTFJobabout two month ago via commit #1814 . So the versionv1should be added forPyTorchJob