Skip to content

Commit

Permalink
Use suggest-changes@v2 (#22667)
Browse files Browse the repository at this point in the history
Use suggest-changes@v2
(parkerbxyz/suggest-changes#36 (comment))
to post suggested changes as comments instead of requested changes to
streamline the review process.

- Also updated the script to `set +e` to ignore exit code only for the
linter run. So that if there is errors in dependency installation we can
still get signals.
  • Loading branch information
justinchuby authored Nov 1, 2024
1 parent ba0bb43 commit f7cabf6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ jobs:
- name: Install dependencies and run lintrunner on all files
run: |
set -e
python -m pip install --user -r requirements-dev.txt
python -m pip install --user lintrunner lintrunner-adapters
python -m pip install --user lintrunner lintrunner-adapters
lintrunner init
set +e
lintrunner f --all-files -v
exit 0
- uses: parkerbxyz/suggest-changes@v1
- uses: parkerbxyz/suggest-changes@v2
with:
comment: 'You can commit the suggested changes from lintrunner.'

0 comments on commit f7cabf6

Please sign in to comment.