Post comments instead of request changes #36
Labels
enhancement
New feature or request
Comments
This was referenced Sep 18, 2024
|
The blocking review from the bot can be dismissed.
That being said, I think it makes sense to make the review more configurable so it can be non-blocking. Pull requests welcome! |
parkerbxyz
added a commit
that referenced
this issue
Oct 30, 2024
Fixes #36 Adds a new `event` input to define the review action you want to perform. The review actions include: `APPROVE`, `REQUEST_CHANGES`, or `COMMENT`. BREAKING CHANGE: Changes the default pull request review action from `REQUEST_CHANGES` to `COMMENT`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/parkerbxyz/suggest-changes/issues/36?shareId=XXXX-XXXX-XXXX-XXXX).
|
I've released v2.0.0, which changes the default pull request review action from - uses: parkerbxyz/suggest-changes@v2
with:
event: 'REQUEST_CHANGES' |
snnn
pushed a commit
to microsoft/onnxruntime
that referenced
this issue
Nov 1, 2024
Use suggest-changes@v2 (parkerbxyz/suggest-changes#36 (comment)) to post suggested changes as comments instead of requested changes to streamline the review process. - Also updated the script to `set +e` to ignore exit code only for the linter run. So that if there is errors in dependency installation we can still get signals.
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this issue
Nov 19, 2024
Use suggest-changes@v2 (parkerbxyz/suggest-changes#36 (comment)) to post suggested changes as comments instead of requested changes to streamline the review process. - Also updated the script to `set +e` to ignore exit code only for the linter run. So that if there is errors in dependency installation we can still get signals.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this issue
Dec 11, 2024
Use suggest-changes@v2 (parkerbxyz/suggest-changes#36 (comment)) to post suggested changes as comments instead of requested changes to streamline the review process. - Also updated the script to `set +e` to ignore exit code only for the linter run. So that if there is errors in dependency installation we can still get signals.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this issue
Dec 11, 2024
Use suggest-changes@v2 (parkerbxyz/suggest-changes#36 (comment)) to post suggested changes as comments instead of requested changes to streamline the review process. - Also updated the script to `set +e` to ignore exit code only for the linter run. So that if there is errors in dependency installation we can still get signals.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this issue
Dec 11, 2024
Use suggest-changes@v2 (parkerbxyz/suggest-changes#36 (comment)) to post suggested changes as comments instead of requested changes to streamline the review process. - Also updated the script to `set +e` to ignore exit code only for the linter run. So that if there is errors in dependency installation we can still get signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this example PR onnx/onnx#6377, the bot left a comment to request change, but there was no resolution of the request change status after the comments were addressed. It would be great if there is an option for the bot to post a "comment" instead of "request for change" response, or is that possible already?
The text was updated successfully, but these errors were encountered: