Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 support #2664

Closed
maxnoe opened this issue Dec 16, 2019 · 17 comments · Fixed by #2747
Closed

Python 3.8 support #2664

maxnoe opened this issue Dec 16, 2019 · 17 comments · Fixed by #2747
Assignees
Labels
feature request request for unsupported feature or enhancement stale issues that have not been addressed in a while; categorized by a bot

Comments

@maxnoe
Copy link

maxnoe commented Dec 16, 2019

Could you also publish wheels for 3.8?

Is there a reason why you don't publish a sdist to PyPI? That way, people could rely on that until a 3.8 wheel is avaiable.

@snnn snnn added contributions welcome external contributions welcome feature request request for unsupported feature or enhancement Python API labels Dec 16, 2019
@snnn
Copy link
Member

snnn commented Dec 16, 2019

We need to patch https://github.com/microsoft/onnxruntime/blob/master/tools/ci_build/build.py a little bit. Some of the code isn't compatible with python 3.8

@snnn
Copy link
Member

snnn commented Dec 27, 2019

Will close it when the wheels are published.

@snnn snnn self-assigned this Dec 27, 2019
@snnn
Copy link
Member

snnn commented Jan 2, 2020

Just checked in one more change, however, there is an on-going issue in our nightly build pipeline, the new packages are still not available for downloading. I'll update this thread when the issue is fixed.

@9dogs
Copy link

9dogs commented Jan 23, 2020

Any updates?

@snnn
Copy link
Member

snnn commented Jan 23, 2020

It's in our nightly build in testpypi.

  1. https://test.pypi.org/project/ort-gpu-nightly/
  2. https://test.pypi.org/project/ort-nightly/

However, Windows gpu for 3.8 is still missing.

@faxu faxu removed the contributions welcome external contributions welcome label Mar 10, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the wontfix label Jul 18, 2020
@stonebig
Copy link

There are wheels for Python-3.8 now. the issue should be closed.
A wheel for Python-3.9beta 5 would be appreciated

@stale stale bot removed the wontfix label Jul 18, 2020
@snnn
Copy link
Member

snnn commented Jul 19, 2020

We should finish the 3.8 support and add 3.9beta there.

@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the stale issues that have not been addressed in a while; categorized by a bot label Sep 20, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically closed due to inactivity. Please reactivate if further support is needed.

@snnn
Copy link
Member

snnn commented Dec 8, 2020

#5697

@olokobayusuf
Copy link

Hey @snnn, I wanted to ask about this. I'm on macOS Big Sur with Python 3.8, but I can't install onnxruntime:

$ python3 --version
Python 3.8.5
$ pip3 --version
pip 20.1.1 from /usr/local/lib/python3.8/site-packages/pip (python 3.8)
$ pip3 install onnxruntime
ERROR: Could not find a version that satisfies the requirement onnxruntime (from versions: none)
ERROR: No matching distribution found for onnxruntime

@snnn
Copy link
Member

snnn commented Dec 9, 2020

That's strange.
Please see:
https://pypi.org/project/onnxruntime/#files

There is a file with name of "onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl"

Could you please manually download the file and let me know if it can be installed?

pip3 install onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl

@olokobayusuf
Copy link

olokobayusuf commented Dec 10, 2020

It seems that the wheel has to be built for macOS Big Sur (11.0.1):

$ pip3 install onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl
ERROR: onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl is not a supported wheel on this platform.

Seems that pip doesn't think there's backwards compatibility between macOS 10.x and macOS 11.

@snnn
Copy link
Member

snnn commented Dec 10, 2020

@olokobayusuf Please upgrade your pip to 20.3.

python3 -m pip install --upgrade pip

I think it will solve the issue. see: pypa/pip#9170

@olokobayusuf
Copy link

@olokobayusuf Please upgrade your pip to 20.3.

python3 -m pip install --upgrade pip

I think it will solve the issue. see: pypa/pip#9170

Yup, that fixed it. Thank you!

@leifwalsh
Copy link

It would still be helpful if you could publish a buildable sdist to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for unsupported feature or enhancement stale issues that have not been addressed in a while; categorized by a bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants