-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.8 support #2664
Comments
We need to patch https://github.com/microsoft/onnxruntime/blob/master/tools/ci_build/build.py a little bit. Some of the code isn't compatible with python 3.8 |
Will close it when the wheels are published. |
Just checked in one more change, however, there is an on-going issue in our nightly build pipeline, the new packages are still not available for downloading. I'll update this thread when the issue is fixed. |
Any updates? |
It's in our nightly build in testpypi. However, Windows gpu for 3.8 is still missing. |
This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details. |
There are wheels for Python-3.8 now. the issue should be closed. |
We should finish the 3.8 support and add 3.9beta there. |
This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details. |
This issue has been automatically closed due to inactivity. Please reactivate if further support is needed. |
Hey @snnn, I wanted to ask about this. I'm on macOS Big Sur with Python 3.8, but I can't install $ python3 --version
Python 3.8.5
$ pip3 --version
pip 20.1.1 from /usr/local/lib/python3.8/site-packages/pip (python 3.8)
$ pip3 install onnxruntime
ERROR: Could not find a version that satisfies the requirement onnxruntime (from versions: none)
ERROR: No matching distribution found for onnxruntime |
That's strange. There is a file with name of "onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl" Could you please manually download the file and let me know if it can be installed? pip3 install onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl |
It seems that the wheel has to be built for macOS Big Sur (11.0.1): $ pip3 install onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl
ERROR: onnxruntime-1.5.2-cp38-cp38-macosx_10_12_x86_64.whl is not a supported wheel on this platform. Seems that |
@olokobayusuf Please upgrade your pip to 20.3.
I think it will solve the issue. see: pypa/pip#9170 |
Yup, that fixed it. Thank you! |
It would still be helpful if you could publish a buildable sdist to PyPI. |
Could you also publish wheels for 3.8?
Is there a reason why you don't publish a
sdist
to PyPI? That way, people could rely on that until a 3.8 wheel is avaiable.The text was updated successfully, but these errors were encountered: