Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Python 3.8 support #4025

Closed
wants to merge 1 commit into from

Conversation

cjermain
Copy link
Contributor

While PyPI provides wheels for Python 3.8 after #2664, this support is not clear from the documentation. This PR adds Python 3.8 to the setup.py and README.md files.

@cjermain cjermain requested a review from a team as a code owner May 25, 2020 16:11
@snnn
Copy link
Member

snnn commented May 25, 2020

But the support isn't completed yet. It still lack the Windows GPU package for python 3.8

@cjermain
Copy link
Contributor Author

Ok, got it. I thought they were all accounted for in 1.3.

@snnn
Copy link
Member

snnn commented May 26, 2020

And I just found that even protobuf doesn't have a 3.8 windows python yet.
https://pypi.org/project/protobuf/3.12.1/#files

We depend on onnx, onnx depends on protobuf.

@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the wontfix label Jul 25, 2020
@cjermain
Copy link
Contributor Author

It looks like the latest protobuf still does not have Python 3.8 support for Windows.

@faxu
Copy link
Contributor

faxu commented Aug 13, 2020

Addressed this in #4778. Pypi package metadata will be updated when full 3.8 support is completed.

@faxu faxu closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants