Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Windows GPU python 3.8 and python 3.9 changes in the release branch #6035

Merged
merged 7 commits into from
Dec 9, 2020

Conversation

snnn
Copy link
Member

@snnn snnn commented Dec 4, 2020

Description:

Revert python 3.8 changes

  1. Revert "Revert some pipeline changes in Add python 3.9 support #5874"
  2. Revert "Add python 3.9 support (Add python 3.9 support #5874)"
  3. Revert "Add support for Python 3.8+ on Windows when CUDA is enabled (Add support for Python 3.8+ on Windows when CUDA is enabled #5956)"
  4. Cherry-pick bug fix in build.py which prevents running some unit tests #5990 to validate the changes.
  5. Regenerate all the CI build docker images to ensure things are consistent.
    Motivation and Context
  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

Will need to reopen #5697 #4035 #2664 #5963

@snnn snnn requested a review from duli2012 December 4, 2020 18:42
@snnn snnn requested a review from a team as a code owner December 4, 2020 18:42
Also ignore an exception occurred for execution providers which generate compiled nodes
@@ -158,8 +156,6 @@ stages:
python.version: '3.7'
Python38:
python.version: '3.8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.8 is still here?

@@ -238,8 +234,6 @@ stages:
python.version: '3.7'
Python38:
python.version: '3.8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added long ago. In the past a few releases, we have almost full support for python 3.8 except lacking Windows GPU package and ARM package.

@jywu-msft
Copy link
Member

what do you think of just respecting CUDA_PATH as I suggested in #5962 (comment)
rather than hardcoding CUDA 10.2?

@snnn snnn changed the title Revert python 3.8 changes Revert Windows GPU python 3.8 and python 3.9 changes Dec 4, 2020
@snnn
Copy link
Member Author

snnn commented Dec 4, 2020

what do you think of just respecting CUDA_PATH as I suggested in #5962 (comment)
rather than hardcoding CUDA 10.2?

Sorry I have no idea. I think the safest way would be revert the recent changes first, get the release branch back to a good state, then we can think how to do it better.

@jywu-msft
Copy link
Member

what do you think of just respecting CUDA_PATH as I suggested in #5962 (comment)
rather than hardcoding CUDA 10.2?

Sorry I have no idea. I think the safest way would be revert the recent changes first, get the release branch back to a good state, then we can think how to do it better.

I have a fix soon (hopefully). Let me share a branch with you. Let me know what you think.

@snnn snnn changed the title Revert Windows GPU python 3.8 and python 3.9 changes Revert Windows GPU python 3.8 and python 3.9 changes in the release branch Dec 4, 2020
@snnn snnn force-pushed the snnn/python38 branch 2 times, most recently from 466fca7 to a031353 Compare December 5, 2020 00:08
* Fix the build break in macos release

* revert android change
@snnn snnn merged commit c38f762 into rel-1.6.0 Dec 9, 2020
@snnn snnn deleted the snnn/python38 branch December 9, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants