-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Windows GPU python 3.8 and python 3.9 changes in the release branch #6035
Conversation
Also ignore an exception occurred for execution providers which generate compiled nodes
@@ -158,8 +156,6 @@ stages: | |||
python.version: '3.7' | |||
Python38: | |||
python.version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python 3.8 is still here?
@@ -238,8 +234,6 @@ stages: | |||
python.version: '3.7' | |||
Python38: | |||
python.version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added long ago. In the past a few releases, we have almost full support for python 3.8 except lacking Windows GPU package and ARM package.
what do you think of just respecting CUDA_PATH as I suggested in #5962 (comment) |
Sorry I have no idea. I think the safest way would be revert the recent changes first, get the release branch back to a good state, then we can think how to do it better. |
I have a fix soon (hopefully). Let me share a branch with you. Let me know what you think. |
466fca7
to
a031353
Compare
* Fix the build break in macos release * revert android change
Description:
Revert python 3.8 changes
Motivation and Context
Will need to reopen #5697 #4035 #2664 #5963