update onnx.patch to apply wasm build break fix #17104
Conversation
There was a problem hiding this comment.
Thanks for the quick update (both in ORT and ONNX)! onnx/onnx#5496 the cherry-pick for ONNX 1.14.1 is ready and probably we can forward it tomorrow. After that, ORT can directly consume that ONNX commit as well.
Also I am curious why the previous PR #16325 does not catch the build issue here. Is it because there are some other additional CIs not running in the PR?
### Description updates the build.bat file in root folder to try best efforts to locate patch.exe. patch.exe is needed to apply patches to some of the dependencies. for example, #17104. However, patch.exe is not available on every windows developer's search path, and if cannot find patch.exe, the build will continue silently. ( as a result, patch is not applied and for patches like #17104, this will cause a build break ) This change adds folder `C:\Program Files\Git\usr\bin` to the PATH, which is the default git installation directory. This may resolve the patch not found issue for most (hopefully) users.
It's a coincident that we temporarily disabled the CI when we are fixing a web CI failure. |
There was a problem hiding this comment.
FYI the latest ONNX 1.14.1 branch now includes your ONNX fix: onnx/onnx#5495
|
I will wait for #17121. If it get merged this PR can close. |
it takes longer as expected to update submodule onnx. let's merge this first. |
### Description updates the build.bat file in root folder to try best efforts to locate patch.exe. patch.exe is needed to apply patches to some of the dependencies. for example, #17104. However, patch.exe is not available on every windows developer's search path, and if cannot find patch.exe, the build will continue silently. ( as a result, patch is not applied and for patches like #17104, this will cause a build break ) This change adds folder `C:\Program Files\Git\usr\bin` to the PATH, which is the default git installation directory. This may resolve the patch not found issue for most (hopefully) users.
### Description This PR fixes build break for WebAssembly introduced in 6986981 (onnx/onnx@435ad2b). This change updates onnx.patch in onnxruntime repo. the corresponding PR in onnx repo is: onnx/onnx#5495. It may takes a while for the next onnx version bump.
…7106) ### Description updates the build.bat file in root folder to try best efforts to locate patch.exe. patch.exe is needed to apply patches to some of the dependencies. for example, microsoft#17104. However, patch.exe is not available on every windows developer's search path, and if cannot find patch.exe, the build will continue silently. ( as a result, patch is not applied and for patches like microsoft#17104, this will cause a build break ) This change adds folder `C:\Program Files\Git\usr\bin` to the PATH, which is the default git installation directory. This may resolve the patch not found issue for most (hopefully) users.
### Description This PR fixes build break for WebAssembly introduced in 6986981 (onnx/onnx@435ad2b). This change updates onnx.patch in onnxruntime repo. the corresponding PR in onnx repo is: onnx/onnx#5495. It may takes a while for the next onnx version bump.
Description
This PR fixes build break for WebAssembly introduced in 6986981 (onnx/onnx@435ad2b).
This change updates onnx.patch in onnxruntime repo. the corresponding PR in onnx repo is: onnx/onnx#5495.
It may takes a while for the next onnx version bump.