try to find patch.exe in git default installation folder #17106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
approved these changes
Aug 11, 2023
|
There is |
jchen351
pushed a commit
that referenced
this pull request
Aug 12, 2023
### Description updates the build.bat file in root folder to try best efforts to locate patch.exe. patch.exe is needed to apply patches to some of the dependencies. for example, #17104. However, patch.exe is not available on every windows developer's search path, and if cannot find patch.exe, the build will continue silently. ( as a result, patch is not applied and for patches like #17104, this will cause a build break ) This change adds folder `C:\Program Files\Git\usr\bin` to the PATH, which is the default git installation directory. This may resolve the patch not found issue for most (hopefully) users.
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…7106) ### Description updates the build.bat file in root folder to try best efforts to locate patch.exe. patch.exe is needed to apply patches to some of the dependencies. for example, microsoft#17104. However, patch.exe is not available on every windows developer's search path, and if cannot find patch.exe, the build will continue silently. ( as a result, patch is not applied and for patches like microsoft#17104, this will cause a build break ) This change adds folder `C:\Program Files\Git\usr\bin` to the PATH, which is the default git installation directory. This may resolve the patch not found issue for most (hopefully) users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates the build.bat file in root folder to try best efforts to locate patch.exe.
patch.exe is needed to apply patches to some of the dependencies. for example, #17104. However, patch.exe is not available on every windows developer's search path, and if cannot find patch.exe, the build will continue silently. ( as a result, patch is not applied and for patches like #17104, this will cause a build break )
This change adds folder
C:\Program Files\Git\usr\binto the PATH, which is the default git installation directory. This may resolve the patch not found issue for most (hopefully) users.