fix(Entire Browser): make sure input recording with japanese IME Work

[YA2KM]

fix(Entire Browser): make sure input recording with japanese IME Work

Input events are not recoreded collectry with japanese IME.

thir problem caused by invaliid key event "Prosess".
"_performAction" receives fuge amount of "Prosess Key event " in a short moment with japanese IME.

This patch fixes this problem.

[YA2KM]

681232289.783875.mp4

[yury-s]

Could you also add a test for this?

[YA2KM]

sure, why not!

[ghost]

All CLA requirements met.

[YA2KM]

@yury-s

I changed my patch with an advice by my boss like this.

packages/playwright-core/src/server/injected/recorder.ts:329
if (['Shift', 'Control', 'Meta', 'Alt', 'Process'].includes(event.key)) return false;

It works fine, But I am not sure where the test file is.

Could you kindly tell me where the file which test "injected/recorder.ts" is?

I suppose that I should just add 'Process' to the test file.

Thank you.

[mxschmitt]

Here would be a nice place to add a test / test this special case:

playwright/tests/library/inspector/cli-codegen-1.spec.ts

Line 228 in 4bec630

test('should fill', async ({ page, openRecorder }) => {

[YA2KM]

Here would be a nice place to add a test / test this special case:

Thank you for your replying.

I heard about the file from my boss.
But, I would like to test the 'Process Key event ' rejection behavior.

I can fill input element by japanese and test will be passed without this patch.

But I can't record japanese Input with playwright codegen.

So ,I think i should modify here.

playwright/tests/library/inspector/cli-codegen-1.spec.ts

Line 281 in 4bec630

test('should press', async ({ page, openRecorder }) => {

I wrote test code like below, But It doesnt work due to timeout.

 const [, sources] = await Promise.all([
      recorder.waitForActionPerformed(),
      page.press('input', 'Process') //timeout.
    ]);

How do I test?
Sorry for your inconvinience.
I am newbie of playwright and not fluent eng speaker.
thank you.

[YA2KM]

@mxschmitt
@yury-s

Hi.
My question is solved by my co-worker.
I appreciate @taiga533 s helping.

Finally, our modify is passed the test on my local enviroment.
(expecting nice result on github actions test.)
Would you mind if I ask you to review our codes?

Thank you.

[yury-s]

@YA2KM heads up, I had to revert the change as the test was failing on all bots. Feel free to open another PR with a passing test.

[mxschmitt]

I think I broke it with my "formatting fixes", let me reland it.