Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(codegen): make sure input recording with japanese IME Wor… #16393

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Aug 9, 2022

…k (#16210)"

This reverts commit 925de8d.

The new test is failing on all bots:

  1) [chromium] › library/inspector/cli-codegen-1.spec.ts:263:3 › cli codegen › should fill japanese text 

    Error: expect(received).toContain(expected) // indexOf

    Expected substring: "
       // Fill input[name=\"name\"]
       await page.locator('input[name=\"name\"]').fill('てすと');"
    Received string:    "const { chromium } = require('playwright');·
    (async () => {
      const browser = await chromium.launch({
        headless: false
      });
      const context = await browser.newContext();·
      // Open new page
      const page = await context.newPage();·
      // Go to about:blank
      await page.goto('about:blank');·
      // Fill input[name=\"name\"]
      await page.locator('input[name=\"name\"]').fill('てすと');·
      // ---------------------
      await context.close();
      await browser.close();
    })();"

      283 |       })()
      284 |     ]);
    > 285 |     expect(sources.get('JavaScript').text).toContain(`
          |                                            ^
      286 |    // Fill input[name="name"]
      287 |    await page.locator('input[name="name"]').fill('てすと');`);
      288 |     expect(sources.get('Java').text).toContain(`

        at /home/runner/work/playwright/playwright/tests/library/inspector/cli-codegen-1.spec.ts:285:44

@yury-s yury-s requested a review from mxschmitt August 9, 2022 23:47
@yury-s yury-s merged commit 1139191 into microsoft:main Aug 9, 2022
@yury-s yury-s deleted the revert-ime-process branch August 9, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants