Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Initial scrollbar implementation for ScrollViewComponentView #12622

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Jan 22, 2024

Description

This adds an initial scrollbar implementation. This covers basic scrollbar usage for horizontal and vertical scrollbars.

Other minor fixes found / implemented as part of this:

  • Implemented PointerRoutedEventArgs::GetCurrentPoint which previously only worked for tags === -1.
  • Added a RoundedRectangle primitive to CompositionSwitcher. (I'd like to move the switch to use that, and remove the switch specific APIs from CompositionSwitcher at some point in the future).
  • Fixed a crash in UIA IsEnabled handling when accessibilityState is set to null.
  • Fixed a crash when shift+tabbing to move focus backwards in the tab loop.

NYI Features for future PRs:

  • shy scrollbars (switching into touch indicators only when mouse not near the scrollbar).
  • Pointer capture when dragging the scrollbar thumb using mouse input.

Screenshots

image
image

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested review from a team as code owners January 22, 2024 21:30
@acoates-ms acoates-ms merged commit c0538df into microsoft:main Jan 22, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants