Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Teams SSO auth unit tests #1053

Closed
Tracked by #1041
, #1094 ,  #1102
...
blackchoey opened this issue Dec 12, 2023 · 0 comments · Fixed by #1112
Closed
Tracked by #1041
, #1094 ,  #1102
...

[C#] Teams SSO auth unit tests #1053

blackchoey opened this issue Dec 12, 2023 · 0 comments · Fixed by #1112
Assignees
@blackchoey
Labels
dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label

Comments

@blackchoey
Copy link
Contributor

Need to investigate how to bypass unsupported class issue during mock, and add unit tests
@blackchoey blackchoey added the dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label label Dec 12, 2023
@blackchoey blackchoey self-assigned this Dec 12, 2023
@blackchoey blackchoey mentioned this issue Dec 13, 2023
Closed
This was referenced Dec 21, 2023
Open
Open
@blackchoey blackchoey mentioned this issue Jan 3, 2024
Merged
1 task
corinagum pushed a commit that referenced this issue Jan 4, 2024
@blackchoey @aacebo
[C#] feat: add unit tests for Teams SSO auth related classes (#1112)
be8825a 
## Linked issues

closes: #1053 #1110

## Details

1. Create an adapter for MSAL library to make the classes testable with
mock
2. Update existing class implementation to use the MSAL library adapter
3. Do not check token cache in TeamsSsoPrompt because the Authentication
handler already checks token cache before invoking the prompt
4. Add unit tests

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

---------

Co-authored-by: Alex Acebo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackchoey blackchoey

Labels
dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[C#] feat: add unit tests for Teams SSO auth related classes microsoft/teams-ai
1 participant
@blackchoey