Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] 06.auth.teamsSSO.messageExtension - Update setup #984

Closed
Tracked by #922
lilyydu opened this issue Dec 1, 2023 · 0 comments · Fixed by #999
Closed
Tracked by #922

[JS] 06.auth.teamsSSO.messageExtension - Update setup #984

lilyydu opened this issue Dec 1, 2023 · 0 comments · Fixed by #999
Assignees

Comments

@lilyydu
Copy link
Collaborator

lilyydu commented Dec 1, 2023

No description provided.

@blackchoey blackchoey self-assigned this Dec 4, 2023
corinagum pushed a commit that referenced this issue Dec 4, 2023
## Linked issues

closes: #984 

## Details

1. Change teams-ai dependency to remote version
2. Update wording
3. Provide differences comparing with other auth sample
4. Change link to relative path
5. Remove install dependency step from `teamsapp.local.yml`

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants