Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Update setup for samples #922

Closed
17 tasks done
Tracked by #916
lilyydu opened this issue Nov 29, 2023 · 0 comments
Closed
17 tasks done
Tracked by #916

[JS] Update setup for samples #922

lilyydu opened this issue Nov 29, 2023 · 0 comments
Assignees

Comments

@lilyydu
Copy link
Collaborator

lilyydu commented Nov 29, 2023

  1. Add sample.env
  2. Remove the AI-related vars from the local YMLs.
  3. Remove yarn install and build in YMLs
  4. Remove duplicate key names in logic
  5. Fix references for MicrosoftAppId, MicrosoftAppPassword. Replace with BOT_ID, and BOT_PASSWORD in logic and YML - respectively. NOTE: might need to update how the adapter is created.
  6. Update docs for set up instructions - just like how it's done in Math Bot & Chat Moderation.

No. 6 examples:

  • Incorrect descriptions
  • Missing table of contents
  • Typos

No. 6 example bot PR: https://github.com/microsoft/teams-ai/pull/969/files#diff-155c7061e7d0a0889267fc8c01cc0dc96ccb57b99ebdf5e651b69f345134a12f

Idea: match WhoBot flow with population of variables.

@lilyydu lilyydu changed the title [JS] Create consistent flow for /env and .env [JS] Add sample.env to samples Dec 1, 2023
@lilyydu lilyydu changed the title [JS] Add sample.env to samples [JS] Update setup for samples Dec 1, 2023
corinagum pushed a commit that referenced this issue Dec 5, 2023
## Linked issues

closes: #966 
associated: #922 

## Details

Removed inconsistent `.launchSettings` flow and updated setup to match
other samples.

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

Co-authored-by: singhk97 <[email protected]>
@lilyydu lilyydu closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants