Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] chore: update setup for ChefBot #1012

Merged
merged 4 commits into from
Dec 5, 2023
Merged

[JS] chore: update setup for ChefBot #1012

merged 4 commits into from
Dec 5, 2023

Conversation

lilyydu
Copy link
Collaborator

@lilyydu lilyydu commented Dec 5, 2023

Linked issues

closes: #966
associated: #922

Details

Removed inconsistent .launchSettings flow and updated setup to match other samples.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@corinagum corinagum merged commit ea204aa into main Dec 5, 2023
@corinagum corinagum deleted the update-chefbot-setup branch December 5, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS] ChefBot - Fix flow with .launchSettings file
3 participants