[JS] feat: add user agent override and internalize `BotAdapter` #1142

aacebo · 2024-01-09T18:54:44Z

Linked issues

closes: #454

Details

In order to configure the User-Agent header for telemetry, I have added the class TeamsBotFrameworkAuthentication which will allow us to control the headers while still giving the devs implementation flexibility:

we can control how the bot adapter is initialized and provide overrides when necessary.
we can add an error handler on the Application class.
we can cut down on botbuilder boilerplate necessary for users to use our library.

js/packages/teams-ai/src/Application.ts

js/packages/teams-ai/package.json

js/packages/teams-ai/src/Application.ts

js/packages/teams-ai/src/MessageExtensions.spec.ts

corinagum

LGTM!

Just a couple comments, will approve immediately after. Thanks Alex!

aacebo added 2 commits January 9, 2024 10:49

internalize BotAdapter initialization and add user agent

c45aada

Update Application.ts

ed24e09

aacebo temporarily deployed to main January 9, 2024 19:00 — with GitHub Actions Inactive

aacebo had a problem deploying to main January 9, 2024 19:00 — with GitHub Actions Failure

Merge branch 'main' into aacebo/1130

1eaa6a6

aacebo temporarily deployed to main January 9, 2024 19:00 — with GitHub Actions Inactive

aacebo had a problem deploying to main January 9, 2024 19:00 — with GitHub Actions Failure

aacebo changed the title ~~feat: add user agent override and internalize BotAdapter~~ [JS] feat: add user agent override and internalize BotAdapter Jan 9, 2024

aacebo temporarily deployed to main January 9, 2024 19:04 — with GitHub Actions Inactive

don't publish source code, only built lib

431a461

aacebo temporarily deployed to main January 9, 2024 19:10 — with GitHub Actions Inactive

aacebo had a problem deploying to main January 9, 2024 19:10 — with GitHub Actions Failure

aacebo temporarily deployed to main January 9, 2024 19:13 — with GitHub Actions Inactive

Merge branch 'main' into aacebo/1130

f14e41e

aacebo temporarily deployed to main January 9, 2024 19:42 — with GitHub Actions Inactive

aacebo had a problem deploying to main January 9, 2024 19:42 — with GitHub Actions Failure

aacebo temporarily deployed to main January 9, 2024 19:45 — with GitHub Actions Inactive

Update Application.ts

c035ca0

aacebo temporarily deployed to main January 9, 2024 19:50 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 9, 2024 19:54 — with GitHub Actions Inactive

Update Application.spec.ts

9b8f21d

aacebo temporarily deployed to main January 9, 2024 21:19 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 9, 2024 21:22 — with GitHub Actions Inactive

Merge branch 'main' into aacebo/1130

9087870

aacebo temporarily deployed to main January 9, 2024 21:28 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 9, 2024 21:31 — with GitHub Actions Inactive

corinagum reviewed Jan 9, 2024

View reviewed changes

js/packages/teams-ai/src/Application.ts Outdated Show resolved Hide resolved

aacebo temporarily deployed to main January 11, 2024 21:27 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 11, 2024 21:31 — with GitHub Actions Inactive

singhk97 reviewed Jan 11, 2024

View reviewed changes

js/packages/teams-ai/package.json Outdated Show resolved Hide resolved

singhk97 reviewed Jan 11, 2024

View reviewed changes

js/packages/teams-ai/src/Application.ts Outdated Show resolved Hide resolved

corinagum reviewed Jan 11, 2024

View reviewed changes

js/packages/teams-ai/src/MessageExtensions.spec.ts Show resolved Hide resolved

corinagum requested changes Jan 11, 2024

View reviewed changes

fix backwards compatibility

367f5f8

aacebo temporarily deployed to main January 11, 2024 22:44 — with GitHub Actions Inactive

Merge branch 'main' into aacebo/1130

3fa4552

aacebo temporarily deployed to main January 11, 2024 22:46 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 11, 2024 22:49 — with GitHub Actions Inactive

add sandbox

6ac6c3d

aacebo temporarily deployed to main January 12, 2024 16:57 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 12, 2024 17:01 — with GitHub Actions Inactive

Update Application.spec.ts

c7266b9

aacebo temporarily deployed to main January 12, 2024 17:21 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 12, 2024 17:25 — with GitHub Actions Inactive

update user agent

0098aa1

aacebo temporarily deployed to main January 12, 2024 17:59 — with GitHub Actions Inactive

aacebo temporarily deployed to main January 12, 2024 18:04 — with GitHub Actions Inactive

corinagum approved these changes Jan 12, 2024

View reviewed changes

lilyydu approved these changes Jan 12, 2024

View reviewed changes

aacebo merged commit 2d43f5c into main Jan 16, 2024
10 checks passed

aacebo deleted the aacebo/1130 branch January 16, 2024 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JS] feat: add user agent override and internalize `BotAdapter` #1142

[JS] feat: add user agent override and internalize `BotAdapter` #1142

aacebo commented Jan 9, 2024 •

edited

Loading

corinagum left a comment

[JS] feat: add user agent override and internalize BotAdapter #1142

[JS] feat: add user agent override and internalize BotAdapter #1142

Conversation

aacebo commented Jan 9, 2024 • edited Loading

Linked issues

Details

corinagum left a comment

Choose a reason for hiding this comment

[JS] feat: add user agent override and internalize `BotAdapter` #1142

[JS] feat: add user agent override and internalize `BotAdapter` #1142

aacebo commented Jan 9, 2024 •

edited

Loading