Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT doesn't close process handles to openconsole.exe #8706

Closed
vefatica opened this issue Jan 5, 2021 · 4 comments · Fixed by #8707
Closed

WT doesn't close process handles to openconsole.exe #8706

vefatica opened this issue Jan 5, 2021 · 4 comments · Fixed by #8707
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@vefatica
Copy link

vefatica commented Jan 5, 2021

Environment

Microsoft Windows 10 Pro for Workstations
10.0.19042.685 (2009, 20H2)
WindowsTerminalPreview_1.5.3242.0_x64

Release version does it too.

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Monitor WT's open "Process" handles while opening/closong new tabs or panes.

Expected behavior

WT will close its newly acquired handle to OpenConsole.exe

Actual behavior

WT does not close the handle

Using HANDLE64.EXE (Sysinternals, could also use their ProcessExplorer) ...

v:\> rem New Instance

v:\> handle64 -a -p windowsterminal.exe | findstr Process
  9DC: Process       OpenConsole.exe(10016)
  A04: Process       cmd.exe(3136)

v:\> rem Open a second tab

v:\> handle64 -a -p windowsterminal.exe | findstr Process
  9DC: Process       OpenConsole.exe(10016)
  A00: Process       OpenConsole.exe(9848)
  A04: Process       cmd.exe(3136)
  AC8: Process       cmd.exe(8480)

v:\> rem Close the newly opened tab

v:\> handle64 -a -p windowsterminal.exe | findstr Process
  9DC: Process       OpenConsole.exe(10016)
  A00: Process       <Non-existant Process>(9848)
  A04: Process       cmd.exe(3136)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 5, 2021
@DHowett
Copy link
Member

DHowett commented Jan 5, 2021

How do you keep finding these things? Do you just routinely check out the handles for all the stuff you run on your machine?

I'm not complaining, but it is strange 😉

@vefatica
Copy link
Author

vefatica commented Jan 5, 2021

I'm generally concerned with performance, especially that of apps which have captured my fancy in some way. And I have several tools (some my own) for observing performance (and I enjoy using them).

In this case, I was trying to find differences between instances of WT which use little CPU when idling and ones which use a lot of CPU when idling (see #8625).

@ghost ghost added the In-PR This issue has a related PR label Jan 5, 2021
@ghost ghost closed this as completed in #8707 Jan 8, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 8, 2021
ghost pushed a commit that referenced this issue Jan 8, 2021
It rather raises the question as to how we missed this.

Closes #8706
DHowett added a commit that referenced this issue Jan 25, 2021
It rather raises the question as to how we missed this.

Closes #8706

(cherry picked from commit 8bef5ee)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8707, which has now been successfully released as Windows Terminal v1.5.10271.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8707, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
…8707)

It rather raises the question as to how we missed this.

Closes microsoft#8706
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants