Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winconpty: close the pty host handle after terminating it #8707

Merged
4 commits merged into from
Jan 8, 2021
Merged

winconpty: close the pty host handle after terminating it #8707

4 commits merged into from
Jan 8, 2021

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jan 5, 2021 •
edited
Loading

It rather raises the question as to how we missed this.

Closes #8706

@DHowett
Copy link
Member Author

DHowett commented Jan 5, 2021

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 5, 2021
@ghost
Copy link

ghost commented Jan 5, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 05 Jan 2021 20:03:06 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

zadjii-msft
zadjii-msft previously approved these changes Jan 5, 2021
View reviewed changes
@zadjii-msft
Copy link
Member

@DHowett FYI, this broke the tests? That makes me a tad bit worried

@zadjii-msft zadjii-msft dismissed their stale review January 7, 2021 17:10

oh no, those tests are broken, which is worrying.

@DHowett
Copy link
Member Author

DHowett commented Jan 7, 2021

What on earth?

@DHowett
Copy link
Member Author

DHowett commented Jan 7, 2021

This looks like another instance of test machine FT flakiness. It doesn't even use ConPTY in these tests!

@DHowett
Copy link
Member Author

DHowett commented Jan 7, 2021 •
edited
Loading

@zadjii-msft this looks like the thing your backoff/retry timer had fixed, but more aggressive:

Error: Verify: IsLessThan(tries, 5): Make sure we set up the new console in time - Values (5, 5) [File: C:\a\1\s\src\host\ft_host\InitTests.cpp, Function: ModuleSetup, Line: 279]

Unrelated to this changeset. I've re-queued the run (APPARENTLY for the fifth time.)

@zadjii-msft
Copy link
Member

Wait, but, I totally saw it fail the ConPtyTests earlier. W E I R D

@DHowett
Copy link
Member Author

DHowett commented Jan 7, 2021

@zadjii-msft clean bill of health after fixing handle jiggler

zadjii-msft
zadjii-msft approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that'll do it

@ghost ghost merged commit 8bef5ee into main Jan 8, 2021
@ghost ghost deleted the dev/duhowett/well-that-was-silly branch January 8, 2021 10:18
DHowett added a commit that referenced this pull request Jan 25, 2021
@DHowett
winconpty: close the pty host handle after terminating it (#8707)
944fddb 
It rather raises the question as to how we missed this.

Closes #8706

(cherry picked from commit 8bef5ee)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal v1.5.10271.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@DHowett @mpela81
winconpty: close the pty host handle after terminating it (microsoft#…
46c8ced 
…8707)

It rather raises the question as to how we missed this.

Closes microsoft#8706
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa miniksa approved these changes

Assignees

@DHowett DHowett

Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WT doesn't close process handles to openconsole.exe
3 participants
@DHowett @zadjii-msft @miniksa