Use float instead of double by default #17100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
double
is probably generally preferable for UI code,our application is essentially a complex wrapper wrapper around
DWrite, D2D and D3D, all of which use
float
exclusively.Of course it also uses XAML, but that one uses
float
for roughly1/3rd of its API functions, so I'm not sure what it prefers.
Additionally, it's mostly a coincidence that we use WinUI/XAML for
Windows Terminal whereas DWrite/D2D/D3D are effectively essential.
This is demonstrated by the fact that we have a
HwndTerminal
,while there's no alternative to e.g. D3D on Windows.
The goal of this PR is that DIP based calculations never end up
mixing
float
anddouble
. This PR also changes opacity-relatedvalues to
float
because I felt like that fits the theme.