Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Convert all existing rules to use a walk function instead of extending AbstractRule #680

Closed
JoshuaKGoldberg opened this issue Dec 15, 2018 · 4 comments · Fixed by #682, #688 or #742
Closed
Labels
Domain: Code Style Rules or repository tasks related to how to style code. Status: Accepting PRs

Comments

@JoshuaKGoldberg
Copy link

Partner to #586: following palantir/tslint#2522, we should be recommending a ts.forEachChild strategy.

Accepting any PRs that take an existing rule and convert it to walk! ✨

@JoshuaKGoldberg
Copy link
Author

JoshuaKGoldberg commented Dec 18, 2018

The change in #682 to no-for-in is a good example of how to approach this 😊

Edit: whoops, allowed the PR to close the issue. Any other rules yet to be converted are still fair game!

@IllusionMH
Copy link
Contributor

Reopening this issue because it tracks migration of all rules and was closed automatically with fixes #NNN text in PR text.

Note to reviewers: check if PR text strictly follows template and will close this one again.

@IllusionMH IllusionMH reopened this Dec 19, 2018
@JoshuaKGoldberg
Copy link
Author

Looks like this was accomplished. Thanks so much folks! 💖

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.