This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Converted react-no-dangerous-html to use a walk function. #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
approved these changes
Dec 30, 2018
|
Rules aren't generally considered part of TSLint's API, so I don't think we should consider this a breaking change. ✔ |
apawast
pushed a commit
to lupine86/tslint-microsoft-contrib
that referenced
this pull request
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
walkfunction instead of extending AbstractRule #680New feature, bugfix, or enhancementIncludes testsDocumentation updateOverview of change:
Converted react-no-dangerous-html to use a walk function.
Is there anything you'd like reviewers to focus on?
The public static
Rule.getExceptions()function was supposedly "Exposed for testing.", but nothing outside of this class used it, so I've removed it. I'm not sure if that's considered a breaking change (it was a public function on an exported class). If it is a breaking change, then I can easily revert it by rolling back the second commit.