This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Converted react-unused-props-and-state to use a walk function. #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
walk
function instead of extending AbstractRule #680New feature, bugfix, or enhancementIncludes testsDocumentation updateOverview of change:
Converted react-unused-props-and-state to use a walk function.
Is there anything you'd like reviewers to focus on?
This one's a bit odd because it sort of does two passes over the AST. It walks everything once, but doesn't step down on
ClassDeclaration
nodes. Then it does a "second pass" by stepping down on theClassDeclaration
nodes it saw in the first pass. I considered splitting it up into two separate callback functions, but I wasn't sure exactly what's expected to be visited on the first pass and what's visited on the second pass, so I just used one callback function which is the equivalent of what the walker class did.