Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

build: enable npm package publication from master branch #878

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

IllusionMH
Copy link
Contributor

PR checklist

Overview of change:

  • adds files "required" for backwards compatibility
  • prevents unintentional publishing from root folder
  • finally updates steps for beta tags on npm 😄
  • bundled tslint.json now will be created from legacy.json (therefore rules that were added after 6.0 were removed from it)

Is there anything you'd like reviewers to focus on?

After applying this PR there should be only three files inside package that differ from latest version:

  1. legacy.json - removed react-a11y-accessible-headings and void-zero rules because they were added in 6.1
  2. package.json - removed scripts to unblock publishing from dist/build
  3. tslint.json - will produce big diff because of different formatting and rules sort. Summary of changes:
    • disabled deprecated no-reserved-keywords (recommended rule variable-name was already enabled)
    • disabled deprecated no-function-constructor-with-string-args, no-increment-decrement, and no-unnecessary-bind rules and enabled corresponding recommended rules from TSLint

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @IllusionMH for tackling this!

I think by now (and probably for a while...) you have a better grasp on this build system than I do, so I have faith in whatever validations you want to perform to make sure this is stable. We should keep in mind that we'll want to test the next release pretty significantly.

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Jun 15, 2019

https://travis-ci.org/microsoft/tslint-microsoft-contrib/jobs/544502075

Your build has been stopped.
Failed to download file: https://nodejs.org/dist/v6.17.1/node-v6.17.1-win-x64.7z
connect ETIMEDOUT 104.20.23.46:443

...well. Restarting.

Edit: great, it passed on rebuild. I'll hold off on merging - all you! 😊

@IllusionMH IllusionMH merged commit bfc28e9 into microsoft:master Jul 29, 2019
@IllusionMH
Copy link
Contributor Author

Verified one more time and haven't found any more differences except mentioned above changes to configuration.

@IllusionMH IllusionMH deleted the release-from-master-869 branch July 29, 2019 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releases from master branch
2 participants