Deprecate ntlm #196
Merged
Deprecate ntlm #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/handlers/ntlm.ts
Outdated
| @@ -1,6 +1,14 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
|
|
|||
| // This handler has been deprecated and new enhancements beyond basic bug fixes will not be taken. | |||
There was a problem hiding this comment.
Nit: Maybe drop " and new enhancements beyond basic bug fixes will not be taken".
There was a problem hiding this comment.
Approving, let's get Zac to sign off too.
There was a problem hiding this comment.
@zachariahcox - are you comfortable with this? Basically, we want to deprecate the NTLM handler because its known to be insecure and we have other better ways to authenticate. We'll leave it in the library because lots of people still use NTLM, but won't take anything new.
stephenmichaelf
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hamzahejja FYI