Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ntlm #196

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Deprecate ntlm #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec02b40
Deprecate ntlm
Jan 10, 2020
60c2dda
Update ntlm.ts
Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/handlers/ntlm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

// This handler has been deprecated.
// Our recommendation is to use one of the other supported handlers due to security concerns around NTLM protocol.
// See these articles for more info:
// * https://securiteam.com/securityreviews/5op0b2kgac/
// * https://www.bleepingcomputer.com/news/security/new-microsoft-ntlm-flaws-may-allow-full-domain-compromise/
// * https://docs.microsoft.com/en-us/archive/blogs/miriamxyra/stop-using-lan-manager-and-ntlmv1 - this one is us (MS) telling people to stop using NTLMV1, and pointing to some issues surrounding V2 that have since been discovered to be worse than thought
// * https://www.helpnetsecurity.com/2019/10/10/ntlm-vulnerabilities/

import ifm = require('../Interfaces');
import http = require("http");
import https = require("https");
Expand Down