Whitelist @jest/jest-diff and @jest/pretty-format
#769
Conversation
douglascayers
changed the title
@jest/jest-diff and @jest/pretty-format@jest/jest-diff and @jest/pretty-format
| @@ -14,6 +14,8 @@ | |||
| @hapi/wreck | |||
| @jest/environment | |||
| @jest/fake-timers | |||
| @jest/jest-diff | |||
| @jest/pretty-format | |||
There was a problem hiding this comment.
These aren't on npm, but jest-diff and pretty-format are. Is there some reason these are not published in the @jest namespace?
- https://www.npmjs.com/package/@jest/jest-diff - not found
- https://www.npmjs.com/package/@jest/pretty-format - not found
- https://www.npmjs.com/package/jest-diff - found (and its github repo points to the jest monorepo)
- https://www.npmjs.com/package/pretty-format - found (and its github repo points to the jest monorepo)
There was a problem hiding this comment.
@sandersn I have no idea since I don't work on the jest codebase. I'm trying to submit changes over on DefinitelyTyped (DefinitelyTyped/DefinitelyTyped#44033) to update typings for jest-environment-puppeteer and that CI process is failing because it can't resolve the jest-diff and pretty-format modules -- which aren't explicitly referenced in the package I'm trying to update, which is more baffling.
I'm trying to figure out what configuration is needed to get the DefinitelyTyped build process to succeed (I've left many comments over there on the PR with my research and attempts so far).
My latest research is documented at DefinitelyTyped/DefinitelyTyped#44033 (comment) if you have any ideas what the DefinitelyTyped error messages mean. One of the errors mentioned adding external libs to this repo's whitelist, so that's how I ended up bothering you here.
Thanks
|
Closing for now as @jablko discovered a different route that may resolve our build errors. |
|
That seems like the right fix. In case you need to revive this PR in the future, I think that it just needs to add |
I think these changes are necessary to support DefinitelyTyped/DefinitelyTyped#44033.
The DefinitelyTyped jest-environment-puppeteer package has transitive dependencies on
@jestand the DefinitelyTyped CI is failing because it can't resolve the external dependencies to@jest/jest-diff(source) and@jest/pretty-format(source).Thanks!