Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Whitelist @jest/jest-diff and @jest/pretty-format #769

Closed
wants to merge 1 commit into from
+2 −0
Closed

Whitelist @jest/jest-diff and @jest/pretty-format #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dependenciesWhitelist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
@hapi/wreck
@jest/environment
@jest/fake-timers
@jest/jest-diff
@jest/pretty-format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't on npm, but jest-diff and pretty-format are. Is there some reason these are not published in the @jest namespace?

Copy link
Author

@douglascayers douglascayers Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandersn I have no idea since I don't work on the jest codebase. I'm trying to submit changes over on DefinitelyTyped (DefinitelyTyped/DefinitelyTyped#44033) to update typings for jest-environment-puppeteer and that CI process is failing because it can't resolve the jest-diff and pretty-format modules -- which aren't explicitly referenced in the package I'm trying to update, which is more baffling.

I'm trying to figure out what configuration is needed to get the DefinitelyTyped build process to succeed (I've left many comments over there on the PR with my research and attempts so far).

My latest research is documented at DefinitelyTyped/DefinitelyTyped#44033 (comment) if you have any ideas what the DefinitelyTyped error messages mean. One of the errors mentioned adding external libs to this repo's whitelist, so that's how I ended up bothering you here.

Thanks

@jest/transform
@jest/types
@loadable/component
Expand Down