Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency features not installed in manifest mode #12315

Closed
AlexAltea opened this issue Jul 7, 2020 · 2 comments · Fixed by #12227
Closed

Dependency features not installed in manifest mode #12315

AlexAltea opened this issue Jul 7, 2020 · 2 comments · Fixed by #12227
Assignees
Labels
info:manifests This PR or Issue pertains to the Manifests feature

Comments

@AlexAltea
Copy link
Contributor

It seems that features in the array of dependencies of vcpkg.json files get ignored by vcpkg install.

Environment

  • OS: Any?
  • Compiler: Any?

To reproduce

Steps to reproduce the behavior:

  1. Create an empty folder with the following vcpkg.json file:
    {
      "name": "xxx",
      "version-string": "0.1.0",
      "dependencies": [
        {
          "name": "capstone",
          "features": [ "x86" ]
        }
      ]
    }
    
  2. Run vcpkg install in that folder.
  3. capstone[core] is installed instead of capstone[x86].
    See: https://github.com/microsoft/vcpkg/blob/master/ports/capstone/CONTROL

Expected behavior

capstone[x86] should have been installed.

@AlexAltea
Copy link
Contributor Author

CC @strega-nil

@strega-nil
Copy link
Contributor

strega-nil commented Jul 7, 2020

I will look into this, it's likely to do with the same thing as #12186

@strega-nil strega-nil added the info:manifests This PR or Issue pertains to the Manifests feature label Jul 7, 2020
strega-nil added a commit to strega-nil/vcpkg that referenced this issue Jul 8, 2020
@LilyWangL LilyWangL self-assigned this Jul 8, 2020
strega-nil added a commit that referenced this issue Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:manifests This PR or Issue pertains to the Manifests feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants